Add new PKCS#11 indestructible attribute feature by sahesaha · Pull Request #404 · OP-TEE/optee_client

sahesaha · 2025-11-03T14:15:26Z

This change defines attributes needed for Indestructible attribute feature.

github-actions · 2025-12-04T02:18:41Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

sahesaha · 2025-12-08T06:30:25Z

Commenting to keep alive.

github-actions · 2026-01-08T02:26:32Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

jenswikl · 2026-01-08T07:23:28Z

Ping @etienne-lms

etienne-lms

Could you refine the commit message: prefix the header line + add a small description in the message body? E.g.:

libckteec: Add PKCS#11 vendor specific indestructible attribute

Add CKA_OPTEE_INDESTRUCTIBLE vendor specific attribute ID
for object that should never be destroyed, even on token re-initialization.

Signed-off-by: ...

etienne-lms · 2026-01-08T09:54:30Z

 #define CKA_SUPPORTED_CMS_ATTRIBUTES	0x0503
 #define CKA_ALLOWED_MECHANISMS		(0x0600 | CKF_ARRAY_ATTRIBUTE)
+/* Vendor Defined Indestructible Attribute */
+#define CKA_INDESTRUCTIBLE      0x80000010


Suggested change

#define CKA_INDESTRUCTIBLE 0x80000010

#define CKA_INDESTRUCTIBLE (0x0010 | CKA_VENDOR_DEFINED)

Also, since it is an OP-TEE specific attribute, I think it should be renamed CKA_OPTEE_INDESTRUCTIBLE.

etienne-lms · 2026-01-08T10:02:03Z

 	/* Vendor extension: reserved for undefined ID (~0U) */
 	PKCS11_CKA_UNDEFINED_ID			= PKCS11_UNDEFINED_ID,
+	/* Vendor Defined Indestructible Attribute */
+	PKCS11_CKA_INDESTRUCTIBLE       = 0x80000010,


For consistency, could you keep the IDs sorted by increasing value:

+ /* Vendor Defined Indestructible Attribute */ + PKCS11_CKA_OPTEE_INDESTRUCTIBLE = 0x80000010, /* Vendor extension: reserved for undefined ID (~0U) */ PKCS11_CKA_UNDEFINED_ID = PKCS11_UNDEFINED_ID,

I think it would be nice to introduce also PKCS11_VENDOR_DEFINED (and also PKCS11_CKA_ARRAY_ATTRIBUTE) macros:

PKCS11_CKA_OPTEE_INDESTRUCTIBLE = (PKCS11_CKA_VENDOR_DEFINED | 0x0010),

sahesaha · 2026-01-08T10:51:27Z

@etienne-lms, addressed and changed the macros accordingly the macro added for this requirement in optee_ta to what you suggested there.

Add CKA_OPTEE_INDESTRUCTIBLE vendor specific attribute ID for object that should never be destroyed, even on token re-initialization. Reviewed-by: Neeraj Soni <neersoni@qti.qualcomm.com> Signed-off-by: Saheli Saha <sahesaha@qti.qualcomm.com>

sahesaha · 2026-01-08T12:44:12Z

@etienne-lms, addressed and changed the macros accordingly the macro added for this requirement in optee_ta to what you suggested there.

etienne-lms · 2026-01-08T17:08:07Z

 	/* Vendor extension: reserved for undefined ID (~0U) */
 	PKCS11_CKA_UNDEFINED_ID			= PKCS11_UNDEFINED_ID,
+	/* Vendor Defined Indestructible Attribute */
+	PKCS11_CKA_OPTEE_INDESTRUCTIBLE               = 0x80000001,


Could you intend with tabulation, and swap the 2 IDs:

Suggested change

/* Vendor extension: reserved for undefined ID (~0U) */

PKCS11_CKA_UNDEFINED_ID = PKCS11_UNDEFINED_ID,

/* Vendor Defined Indestructible Attribute */

PKCS11_CKA_OPTEE_INDESTRUCTIBLE = 0x80000001,

/* Vendor Defined Indestructible Attribute */

PKCS11_CKA_OPTEE_INDESTRUCTIBLE = 0x80000001,

/* Vendor extension: reserved for undefined ID (~0U) */

PKCS11_CKA_UNDEFINED_ID = PKCS11_UNDEFINED_ID,

github-actions · 2026-02-08T03:33:08Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

sahesaha · 2026-02-16T10:46:03Z

Hi @etienne-lms, can you help reopening this PR so that I can correctly commit as per you latest comment. Actually, was engaged in some tasks since last month, due to inactivity this PR somehow got closed.

etienne-lms · 2026-02-16T14:13:12Z

Thanks @jforissier.
@sahesaha, just in case you get a P-R staled and closed, don't mind creating a new one with your very same changes, or an updated version. You can still add a comment referencing the old P-R, for the record.

github-actions · 2026-03-19T03:19:14Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

sahesaha · 2026-03-19T10:05:05Z

Commenting to keep alive.

github-actions · 2026-04-19T03:48:22Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

sahesaha · 2026-04-24T05:09:07Z

@jenswi-linaro can you help restore the PR?

github-actions · 2026-05-25T04:49:05Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

sahesaha · 2026-05-25T05:42:43Z

Commenting to keep alive.

jenswikl · 2026-05-26T07:47:56Z

What's the next step for this PR?

github-actions · 2026-06-26T04:37:46Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

sahesaha · 2026-06-29T10:56:56Z

Commenting to keep alive.

sahesaha force-pushed the add-new-pkcs11-Indestructible-attribute branch from 83f89d6 to 72f1d94 Compare November 3, 2025 14:21

github-actions Bot added the Stale label Dec 4, 2025

github-actions Bot removed the Stale label Dec 9, 2025

github-actions Bot added the Stale label Jan 8, 2026

jenswikl removed the Stale label Jan 8, 2026

etienne-lms reviewed Jan 8, 2026

View reviewed changes

sahesaha force-pushed the add-new-pkcs11-Indestructible-attribute branch from 72f1d94 to 8f1a5cf Compare January 8, 2026 10:49

sahesaha force-pushed the add-new-pkcs11-Indestructible-attribute branch from 8f1a5cf to 2234a7a Compare January 8, 2026 12:42

sahesaha force-pushed the add-new-pkcs11-Indestructible-attribute branch from 2234a7a to ba80ea5 Compare January 8, 2026 12:43

etienne-lms reviewed Jan 8, 2026

View reviewed changes

github-actions Bot added the Stale label Feb 8, 2026

github-actions Bot closed this Feb 14, 2026

jforissier reopened this Feb 16, 2026

github-actions Bot removed the Stale label Feb 17, 2026

github-actions Bot added the Stale label Mar 19, 2026

github-actions Bot removed the Stale label Mar 20, 2026

github-actions Bot added the Stale label Apr 19, 2026

github-actions Bot closed this Apr 24, 2026

jenswikl reopened this Apr 24, 2026

jenswikl removed the Stale label Apr 24, 2026

github-actions Bot added the Stale label May 25, 2026

github-actions Bot removed the Stale label May 26, 2026

github-actions Bot added the Stale label Jun 26, 2026

github-actions Bot removed the Stale label Jun 30, 2026

	#define CKA_INDESTRUCTIBLE 0x80000010
	#define CKA_INDESTRUCTIBLE (0x0010 \| CKA_VENDOR_DEFINED)

Uh oh!

Conversation

sahesaha commented Nov 3, 2025

Uh oh!

github-actions Bot commented Dec 4, 2025

Uh oh!

sahesaha commented Dec 8, 2025

Uh oh!

github-actions Bot commented Jan 8, 2026

Uh oh!

jenswikl commented Jan 8, 2026

Uh oh!

etienne-lms left a comment

Choose a reason for hiding this comment

Uh oh!

etienne-lms Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

etienne-lms Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

sahesaha commented Jan 8, 2026

Uh oh!

sahesaha commented Jan 8, 2026

Uh oh!

etienne-lms Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 8, 2026

Uh oh!

sahesaha commented Feb 16, 2026

Uh oh!

etienne-lms commented Feb 16, 2026

Uh oh!

github-actions Bot commented Mar 19, 2026

Uh oh!

sahesaha commented Mar 19, 2026

Uh oh!

github-actions Bot commented Apr 19, 2026

Uh oh!

sahesaha commented Apr 24, 2026

Uh oh!

github-actions Bot commented May 25, 2026

Uh oh!

sahesaha commented May 25, 2026

Uh oh!

jenswikl commented May 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

sahesaha commented Jun 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants