JPEG2000 writer: remove NUL terminated byte at end of payload of 'lbl ' and 'xml ' boxes #13450
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
force-pushed
the
jp2_remove_nul_characer
branch
from
dc9fd80 to
3f7625a
Compare
rouault
force-pushed
the
jp2_remove_nul_characer
branch
4 times, most recently
from
1952c43 to
c582208
Compare
… ' and 'xml ' boxes For label boxes, the spec is pretty explicit about that: "Label strings are not null-terminated" Cf https://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-T.801-200208-S!!PDF-E&type=items "M.11.13 Label box", page 197 For XML boxes, nothing explicit, but in the absence of a statement, null-terminating byte doesn't seem necessary. Furthermore jpylyzer documentation at https://jpylyzer.openpreservation.org/doc/latest/userManual.html has a 'nullxml' option because 'Apparently some old versions of the Kakadu demo applications would erroneously add a null-byte to embedded XML'. Fixes https://lists.osgeo.org/pipermail/gdal-dev/2025-November/061180.html Reported-by: Brad Hards <[email protected]>
rouault
force-pushed
the
jp2_remove_nul_characer
branch
from
c582208 to
b1530f9
Compare
Contributor
ISO/IEC 15444-16:2024 Section I.7.1 says that DATA shall contain a well-formed XML document, and NUL doesn't appear to be valid in XML. So I think this is correct. I built this branch, generated a test file, and things seem better. Thanks for the quick fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For label boxes, the spec is pretty explicit about that: "Label strings are not null-terminated" Cf
https://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-T.801-200208-S!!PDF-E&type=items "M.11.13 Label box", page 197
For XML boxes, nothing explicit, but in the absence of a statement, null-terminating byte doesn't seem necessary. Furthermore jpylyzer documentation at https://jpylyzer.openpreservation.org/doc/latest/userManual.html has a 'nullxml' option because 'Apparently some old versions of the Kakadu demo applications would erroneously add a null-byte to embedded XML'.
Fixes https://lists.osgeo.org/pipermail/gdal-dev/2025-November/061180.html
Reported-by: Brad Hards [email protected]