wxGUI/tplot: Make the window resizable - #7820
Open
saket0187 wants to merge 1 commit into
Open
Conversation
Member
|
Thanks, @saket0187 for addressing this. The proposed changes work fine. When I went back to the Add_stds branch after testing this, I - however - could not reproduce the problematic behavior I experienced on that branch either. So it may have been a temporary (and maybe WSL related) issue. Unfortunately, I am not that familiar with WX specific code. @petrasovaa do you have any opinion about this PR? Does it make sense any way? |
Contributor
|
Generally this makes sense and I tested on linux. One thing we could add here is to increase the padding around the input widgets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue reported by @ninsbl.
Although I cannot verify the changes directly since I am on macOS, I hope this resolves it. @ninsbl, could you please test this? If it doesn't work, we can either close this PR or pass it along to someone else.
AI Summary
This PR fixes an issue where the g.gui.tplot window could only be resized via maximize, not by dragging its edges. The frame previously had no sizer of its own and was fit directly to its content's minimum size with no explicit minimum set, leaving no room to shrink and (on GTK) no reliable resize grip to grow from. The fix gives the frame its own sizer wrapping the main panel, fits through that sizer (preserving the original opening size while capping at the display area), and sets an explicit 400×400 minimum so the window can be dragged smaller; nothing in the codebase sets a maximum, so growing was never actually blocked by wx. It also removes five stray sizer.Fit(self) calls on notebook sub-panels that were mistakenly resizing the whole frame instead of their own panel.Note: Claude was used as a coding assistant for this PR..