Support for bounds, initial guess, and threhold inputs #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oliverchampion
left a comment
oliverchampion
left a comment
There was a problem hiding this comment.
If we get this merged, the unit testing from my merge may help verify the bounds are properly implemented :)
Bneijndorff
reviewed
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went through each standardized algorithm and checked/added support for bounds, initial guesses, and thresholds where applicable.
Additionally, the algorithms now have the following boolean attributes which can be used to filter algorithms in testing.
supported_bounds
supported_initial_guess
supported_thresholds