improve error handling and add negative tests for DeckService#2774
Open
theanand108 wants to merge 1 commit intoOWASP:masterfrom
Open
improve error handling and add negative tests for DeckService#2774theanand108 wants to merge 1 commit intoOWASP:masterfrom
theanand108 wants to merge 1 commit intoOWASP:masterfrom
Conversation
theanand108
force-pushed
the
patch-1
branch
8 times, most recently
from
93ddeee to
0ae4a87
Compare
- Added contextual logging for missing markdown files - Added a minimal targeted test to satisfy branch coverage threshold - Removed unnecessary test additions to keep changes focused - No production code changes
Contributor
Author
|
Hi @sydseter, I’ve addressed the feedback regarding test coverage. The changes have been reduced to a minimal, targeted test addition that covers the previously untested edge branches and brings the overall branch coverage above the required threshold. I also removed unrelated or excessive changes to keep the PR focused strictly on improving test coverage, without modifying existing logic. Please let me know if any further adjustments are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves error handling in DeckService when markdown files are missing and adds negative test cases to improve branch coverage.
Changes include:
This improves maintainability and debugging while keeping the existing architecture unchanged.
Resolved or fixed issue: #2747
AI Tool Disclosure
Affirmation