Skip to content

*: check fee recipient on local#4474

Merged
KaloyanTanev merged 3 commits intomainfrom
kalo/check-fee-recipient-on-local
Apr 15, 2026
Merged

*: check fee recipient on local#4474
KaloyanTanev merged 3 commits intomainfrom
kalo/check-fee-recipient-on-local

Conversation

@KaloyanTanev
Copy link
Copy Markdown
Collaborator

Recently we had an issue where the prepare beacon proposer request at a BN was failing silently, because it was passing at another BN.

This PR changes the checks for the warning of mismatching fee recipient. Previously the check was triggered on MEV disabled, now it checks on block being local (which is the case when MEV fails for one reason or another).

I've added also a healthcheck for the fee recipient mismatching.

Mind you, this won't solve the issue, as it requires greater refactoring on how things work in go-eth2-client, but it will make it easier to spot such issues.

category: feature
ticket: none

@KaloyanTanev KaloyanTanev added this to the v1.11.0 milestone Apr 14, 2026
@KaloyanTanev KaloyanTanev requested a review from pinebit April 14, 2026 12:18
@KaloyanTanev KaloyanTanev self-assigned this Apr 14, 2026
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.52%. Comparing base (d3c1027) to head (c6b1ac4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
app/health/checks.go 60.00% 1 Missing and 1 partial ⚠️
core/fetcher/fetcher.go 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4474      +/-   ##
==========================================
- Coverage   56.57%   56.52%   -0.06%     
==========================================
  Files         245      245              
  Lines       32826    32819       -7     
==========================================
- Hits        18572    18551      -21     
- Misses      11893    11906      +13     
- Partials     2361     2362       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaloyanTanev KaloyanTanev modified the milestones: v1.11.0, v1.10.0 Apr 15, 2026
@KaloyanTanev KaloyanTanev merged commit 094953a into main Apr 15, 2026
10 of 11 checks passed
@KaloyanTanev KaloyanTanev deleted the kalo/check-fee-recipient-on-local branch April 15, 2026 07:41
KaloyanTanev added a commit that referenced this pull request Apr 15, 2026
* Fix warning for mismatching fee recipient to be on blinded block rather than PBS enabled

* Add metrics and healthchecks

* Fix metrics.md
@KaloyanTanev KaloyanTanev mentioned this pull request Apr 15, 2026
KaloyanTanev added a commit that referenced this pull request Apr 15, 2026
* Fix warning for mismatching fee recipient to be on blinded block rather than PBS enabled

* Add metrics and healthchecks

* Fix metrics.md
KaloyanTanev added a commit that referenced this pull request Apr 15, 2026
* *: bumped debian base (#4475)

* *: check fee recipient on local (#4474)

* Fix warning for mismatching fee recipient to be on blinded block rather than PBS enabled

* Add metrics and healthchecks

* Fix metrics.md

---------

Co-authored-by: Andrei Smirnov <andrei@obol.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants