app/eth2wrap: fix mutation of pointer#4488
Merged
KaloyanTanev merged 2 commits intomain-v1.9from Apr 22, 2026
Merged
Conversation
* Fix mutation of pointer * Compare contents, not only lengths in the fast path; add more tests * Address PR review comments * Fix linter
pinebit
approved these changes
Apr 22, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main-v1.9 #4488 +/- ##
=============================================
- Coverage 56.53% 55.98% -0.56%
=============================================
Files 237 237
Lines 31720 40542 +8822
=============================================
+ Hits 17933 22696 +4763
- Misses 11494 15550 +4056
- Partials 2293 2296 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.9.4-rc1
#4486
category: bug
ticket: none