bug: Handling race condition #2408
Open
+67
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2025 12:53
jkasten2
requested changes
Nov 12, 2025
Comment on lines
+332
to
+342
| // Check state and provide appropriate error messages | ||
| when (initState) { | ||
| InitState.FAILED -> { | ||
| throw IllegalStateException("Initialization failed. Cannot proceed.") | ||
| } | ||
| InitState.NOT_STARTED -> { | ||
| throw IllegalStateException("Must call 'initWithContext' before 'logout'") | ||
| } | ||
| InitState.IN_PROGRESS, InitState.SUCCESS -> { | ||
| // Continue - these states allow proceeding (will wait if needed) | ||
| } |
Member
There was a problem hiding this comment.
Duplicate code, can we make a function for this?
jinliu9508
reviewed
Nov 24, 2025
|
|
||
| if (!initState.isSDKAccessible()) { | ||
| throw IllegalStateException("Must call 'initWithContext' before 'login'") | ||
| // Check state and provide appropriate error messages |
Contributor
There was a problem hiding this comment.
Can isSDKAccessible() be changed to something like checkSDKAccessible() so that it throws proper error messages based on initState, and do nothing if allow proceeding?
| } | ||
| } | ||
|
|
||
| waitForInit() |
Contributor
There was a problem hiding this comment.
We are essentially checking init state before and after waitForInit(). Should we let waitForInit() handle the throwing/proceeding based on the initState so we don't need to check for the state again in the usage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Handling race condition during initWithContext
Details
Motivation
#2192 (comment)
To address this issue
Scope
Internal racecondition handling.
Testing
Unit testing
NA
Manual testing
Smoke tested the app
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is