Fix cached_clines counter leak on invalidation with waiters#937
Merged
robertbaldyga merged 2 commits intoOpen-CAS:masterfrom Mar 11, 2026
Merged
Conversation
robertbaldyga
force-pushed
the
fix-cache-line-accounting-on-inv
branch
from
96ee842 to
f694366
Compare
Co-developed-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
When a cache line becomes fully invalid but has waiters __set_cache_line_invalid() returns early without decrementing cached_clines. The new owner that gets the lock may then increment the counter again, causing a permanent leak. Fix by decrementing the occupancy counter before the waiter check, since the counter must reflect the actual valid state of the line regardless of whether there are waiters. Co-developed-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
robertbaldyga
force-pushed
the
fix-cache-line-accounting-on-inv
branch
from
f694366 to
dbf16af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.