[agent] chore(PSScriptAnalyzer): add PSScriptAnalyzer on CI#145
Merged
RomuDeuxfois merged 6 commits intorelease/currentfrom Mar 20, 2026
Merged
[agent] chore(PSScriptAnalyzer): add PSScriptAnalyzer on CI#145RomuDeuxfois merged 6 commits intorelease/currentfrom
RomuDeuxfois merged 6 commits intorelease/currentfrom
Conversation
RomuDeuxfois
force-pushed
the
improvment/PSScriptAnalyzer
branch
from
bae6c80 to
1a7fced
Compare
damgouj
approved these changes
Mar 20, 2026
Member
damgouj
left a comment
damgouj
left a comment
There was a problem hiding this comment.
Just a quick remark but tested OK.
Thanks for the powershell linter, we had problems sometimes according to the Windows version/arch/... and have now the right Powershell commands are great !
| - run: | ||
| name: Lint PowerShell installer scripts (PSScriptAnalyzer) | ||
| shell: powershell.exe | ||
| command: .\installer\windows\Run-Lint.ps1 |
Member
There was a problem hiding this comment.
suggestion: could you clarify in the README how to launch it in local dev env ?
Member
Author
There was a problem hiding this comment.
@copilot can you add the demands from the comment on the code ?
Member
Author
There was a problem hiding this comment.
@damgouj we added it :)
Thank you for the review !
|
@RomuDeuxfois I've opened a new pull request, #148, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: RomuDeuxfois <53513584+RomuDeuxfois@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.