lib: Use PROJECT_SYSTEM to provide compile time warning#360
lib: Use PROJECT_SYSTEM to provide compile time warning#360glneo wants to merge 1 commit intoOpenAMP:mainfrom
Conversation
|
I would prefer to limit the use of cmake variable in source code when possible. Could you detail side effect you observe? |
|
What happens here for example is if I Maybe an easier solution is just to have the message state: " |
edmooring
left a comment
There was a problem hiding this comment.
I like your second solution avoiding the CMake variables in the code better.
+1 for this solution |
Some of these were not correct in some spots. Instead of trying to include the name of the current file in this warning (which might change), only state which file should be included instead. Signed-off-by: Andrew Davis <afd@ti.com>
Several of these were not correct in some spots. Use the automatic replacement to fill this in when installing the headers.