README: remove deprecated cache options#685
Open
Jiaqi-YP7 wants to merge 1 commit into
Open
Conversation
Remove the split dcache CMake options from the README. The options were removed by d183f24 after being deprecated in favor of WITH_DCACHE. Document only WITH_DCACHE as the supported way to enable cache operations for vrings, buffers and resource table. Signed-off-by: Jiaqi Yao <yaojiaqi@lixiang.com>
Jiaqi-YP7
force-pushed
the
fix/readme-dcache-options
branch
from
0939d52 to
16fbe99
Compare
Author
|
The current CI check is failing on the documentation build step, but my changes don't touch any of those files. Could anyone advise on how to handle this? (Apologies if I missed a step—this is my first time contributing to OpenAMP. If I did anything wrong, please let me know and I will gladly fix it!) |
Collaborator
Yes you can ignore the doc generation fail. This PR just needs a second review before been merged.
Nothing missed it is a good first contribution 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The split dcache CMake options were removed by d183f24 after being deprecated in favor of WITH_DCACHE. #667
Update the README to document only WITH_DCACHE as the supported option for enabling cache operations on vrings, buffers and resource table.