Skip to content

legacy_apps: xlnx: fix build system for native cmake build#107

Open
tnmysh wants to merge 1 commit into
OpenAMP:mainfrom
tnmysh:fix_native_cmake_build
Open

legacy_apps: xlnx: fix build system for native cmake build#107
tnmysh wants to merge 1 commit into
OpenAMP:mainfrom
tnmysh:fix_native_cmake_build

Conversation

@tnmysh
Copy link
Copy Markdown
Collaborator

@tnmysh tnmysh commented May 12, 2026

OPENAMP_APP_NAME variable is needed for xilinx specific build tools. Native cmake build doesn't need this variable, and so if it's not found then do not fail, and include project machine direcotry. This allows native cmake build to continue.

Comment thread examples/legacy_apps/machine/xlnx/CMakeLists.txt
@tnmysh tnmysh force-pushed the fix_native_cmake_build branch from c538fc5 to fd186d9 Compare May 14, 2026 03:10
@arnopo arnopo requested review from arnopo and edmooring May 18, 2026 07:09
Copy link
Copy Markdown
Collaborator

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment else LGTM

Comment thread examples/legacy_apps/machine/xlnx/CMakeLists.txt Outdated
@tnmysh tnmysh force-pushed the fix_native_cmake_build branch from fd186d9 to 01305e3 Compare May 18, 2026 14:40
@arnopo
Copy link
Copy Markdown
Collaborator

arnopo commented May 19, 2026

@tnmysh could you rebase it on top of main branch to check if this solves the doc generation issue?

OPENAMP_APP_NAME variable is needed for xilinx specific build tools.
Native cmake build doesn't need this variable, and so if it's not found
then do not fail, and include project machine direcotry. This allows
native cmake build to continue.

Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
@tnmysh tnmysh force-pushed the fix_native_cmake_build branch from 01305e3 to 3a669dd Compare May 20, 2026 15:14
@tnmysh
Copy link
Copy Markdown
Collaborator Author

tnmysh commented May 20, 2026

@tnmysh could you rebase it on top of main branch to check if this solves the doc generation issue?

@arnopo I think the read-docs error is still there.

@arnopo arnopo added this to the Release V2026.04 milestone May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants