Skip to content

--state option outputs metadata #508

Open
Bug
#932
Open
--state option outputs metadata#508
Bug
#932
Labels
good first issue

Description

@Dogacel
Dogacel
opened on Apr 18, 2023

From help,

    --state                     Only output diff state: no_changes,
                                incompatible, compatible

this doesn't align with reality. We had a case where the state outputted metadata.

Caused by this line:

openapi-diff/cli/src/main/java/org/openapitools/openapidiff/cli/Main.java

Line 203 in 1de574d

System.out.println(result.isChanged().getValue());

We can simply

openapi-diff/core/src/main/java/org/openapitools/openapidiff/core/model/DiffResult.java

Line 5 in 1de574d

public enum DiffResult {

to include something like

public DiffResult toStateDiff() {
  if (this.isUnchanged()) {
    return DiffResult.UNCHANGED;
  }

 if (this.isCompatible()) {
    return DiffResult.COMPATIBLE;
 }

 return DiffResult.INCOMPATIBLE;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issue

    Type

    Bug

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions