Repository navigation
fix(security): remove default database credentials - #315
Merged
Merged
Conversation
Signed-off-by: TIANHE <TIANHE@GMAIL.COM>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: TIANHE <TIANHE@GMAIL.COM>
Signed-off-by: TIANHE <TIANHE@GMAIL.COM>
Signed-off-by: TIANHE <TIANHE@GMAIL.COM>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
POSTGRES_PASSWORDis missing.envor the running PostgreSQL container and refuse unsafe upgrades when an existing volume cannot be matchedSecurity impact
This addresses the 13 SonarQube default-password Blockers and hardens the 7 reported path-traversal flows without making the recommended one-command installation more complex.
Existing installer-based deployments keep their random password. Legacy manual deployments recover the current password rather than silently rotating it and disconnecting the existing PostgreSQL volume.
Validation
docker compose config --quietPOSTGRES_PASSWORDis absent