Add native streamer app shortcut integration by zaloguj12 · Pull Request #469 · OpenCloudGaming/OpenNOW

zaloguj12 · 2026-05-16T16:16:39Z

Description

pass the existing configurable stream shortcut bindings into the native streamer session context
add a native shortcut matcher around the Win32/GStreamer input bridge so app shortcuts are intercepted before being forwarded into the stream
route native shortcut actions back through the existing renderer control flow, while keeping native pointer-lock capture toggling local to the streamer window

Verification

npm --prefix opennow-stable run typecheck
npm --prefix opennow-stable run build
cargo test (in native/opennow-streamer)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec7c564dc7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

capy-ai · 2026-05-17T22:35:27Z

Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews.

zaloguj12 · 2026-05-17T22:37:55Z

Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews.

son?

zortos293 · 2026-05-18T10:22:49Z

@zaloguj12 will look into this ;)

zortos293 · 2026-05-18T10:23:19Z

can you fix codex issues

zaloguj12 · 2026-05-18T10:28:22Z

i will try when i get home

zaloguj12 · 2026-05-19T15:30:38Z

@zortos293 should be fixed

zaloguj12 · 2026-05-19T20:45:39Z

nvm

zaloguj12 · 2026-05-20T21:43:29Z

now should be fine 👍

Kief5555 · 2026-05-31T06:53:00Z

@zaloguj12 please update the branch with the current ref

zaloguj12 · 2026-05-31T16:38:44Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30dc5913ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Made by codex

zaloguj12 · 2026-05-31T17:02:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d559f2309

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

This PR adds native streamer shortcut integration by sending the user-configured shortcut bindings into the native streamer session context, intercepting matching shortcuts in the Win32 input bridge before forwarding input to the stream, and routing shortcut actions back into the existing renderer-side control flow (while keeping native pointer-lock capture toggling local to the streamer window).

Changes:

Extended the shared session context/protocol to include shortcut bindings, plus a new native “shortcut” event and an IPC path to update bindings during an active session.
Implemented a Windows native shortcut matcher in the Rust streamer that suppresses matched key events and emits shortcut actions back to the app.
Added renderer plumbing to handle native shortcut actions (including screenshot/recording via a small intra-renderer event bridge).

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
opennow-stable/src/shared/nativeStreamer.ts	Adds `update-shortcuts` command and a `shortcut` event to the native streamer message contract.
opennow-stable/src/shared/ipc.ts	Introduces `NATIVE_UPDATE_SHORTCUTS` IPC channel constant.
opennow-stable/src/shared/gfn.ts	Defines shortcut action/bindings types, includes bindings in native session context, and adds `updateNativeShortcuts` to `OpenNowApi`.
opennow-stable/src/shared/gfn.test.ts	Updates unit test to pass/verify shortcut bindings in the native session context.
opennow-stable/src/renderer/src/streamShortcutActions.ts	Adds a renderer-local event helper for dispatching/listening to native shortcut actions.
opennow-stable/src/renderer/src/components/StreamView.tsx	Listens for native shortcut actions for screenshot/recording and keeps local key handling for those features.
opennow-stable/src/renderer/src/App.tsx	Builds/pushes native shortcut bindings, listens for native shortcut events, and routes actions through existing controls.
opennow-stable/src/preload/index.ts	Wires `updateNativeShortcuts` to IPC send.
opennow-stable/src/main/signaling/signalingCoordinator.ts	Adds IPC listener to update native shortcut bindings and forwards updates to the native streamer manager.
opennow-stable/src/main/nativeStreamer/manager.ts	Sends `update-shortcuts` requests to the native streamer and emits `native-shortcut` events to the renderer.
native/opennow-streamer/src/shortcuts.rs	Implements parsing/matching of shortcut strings to Win32 key/modifier combos (with tests).
native/opennow-streamer/src/protocol.rs	Adds shortcut bindings and shortcut action enum to the native streamer JSON protocol, plus a `shortcut` event variant.
native/opennow-streamer/src/main.rs	Dispatches the new `update-shortcuts` command to the backend.
native/opennow-streamer/src/gstreamer_platform.rs	Hooks shortcut matching into the Win32 window proc and updates raw input handling to suppress matched keys.
native/opennow-streamer/src/gstreamer_input.rs	Forwards shortcut events immediately to the event channel (even before input readiness).
native/opennow-streamer/src/gstreamer_backend.rs	Applies shortcut bindings on start/offer, supports runtime updates, and clears bindings on stop.
native/opennow-streamer/src/backend.rs	Extends backend trait + stub backend to accept the `update-shortcuts` command.

Made by codex

zaloguj12 · 2026-06-01T12:53:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c6143d6d2b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-01T13:00:35Z

+    screenshot: "",
+    toggleRecording: "",


Preserve native media shortcut bindings

When the native streamer is active the Win32/GStreamer window owns keyboard focus, so the renderer StreamView keydown listener cannot see the configured screenshot/recording hotkeys. Sending empty bindings here means the native matcher never intercepts F11/F12 (or user-customized values), and the existing screenshot/recording shortcuts stop working for native sessions even though the shared context and native protocol now carry those actions.

Useful? React with 👍 / 👎.

capy-ai · 2026-06-01T13:05:30Z

+    match upper.as_str() {
+        "BACKSPACE" => parsed_key(VK_BACK),
+        "TAB" => parsed_key(VK_TAB),
+        "ENTER" => parsed_scancode_key(VK_RETURN, SCANCODE_ENTER),


[🟡 Medium] [🔵 Bug]

The matcher now requires exact scancode matches, and this change constrains ENTER to SCANCODE_ENTER while NUMPADENTER uses a different scancode. Upstream shortcut capture canonicalizes both Enter variants to Enter, so a user binding recorded from numpad Enter is serialized as ENTER and will not trigger on numpad Enter in native matching. Either keep ENTER scancode-agnostic (legacy behavior) or ensure capture/serialization emits NUMPADENTER distinctly.

// native/opennow-streamer/src/shortcuts.rs match upper.as_str() { "ENTER" => parsed_scancode_key(VK_RETURN, SCANCODE_ENTER), "NUMPADENTER" => parsed_scancode_key(VK_RETURN, SCANCODE_NUMPAD_ENTER), "PAUSE" => parsed_key(VK_PAUSE),

capy-ai · 2026-06-01T13:05:31Z

+            return false;
+        };
+
+        suppressed_keys.insert(key_id);


[🟡 Medium] [🔵 Bug]

A suppressed key is inserted on legacy keydown and only removed on legacy keyup, but the PR switches capture to raw input (RIDEV_NOLEGACY) during shortcut actions; when keyup is delivered via raw path (or not delivered as legacy), the stale key remains in LEGACY_SUPPRESSED_KEYS, causing later presses of that key to be swallowed unexpectedly. Clear the suppressed-key set when capture mode changes/release occurs (and during teardown) so suppression state cannot leak across input paths.

// native/opennow-streamer/src/gstreamer_platform.rs if !pressed { return suppressed_keys.remove(&key_id); } ... suppressed_keys.insert(key_id);

zortos293 · 2026-06-02T06:30:22Z

someone on windows needs to test this atm not on windows

zaloguj12 added 3 commits May 16, 2026 00:05

Add native streamer app shortcut integration

9d26d5f

fix codex review stuff

ed39e4f

Add native streamer app shortcut integration (#16)

ec7c564

chatgpt-codex-connector Bot reviewed May 16, 2026

View reviewed changes

Comment thread native/opennow-streamer/src/gstreamer_input.rs Outdated

Comment thread opennow-stable/src/renderer/src/App.tsx

Comment thread native/opennow-streamer/src/gstreamer_platform.rs Outdated

Merge branch 'OpenCloudGaming:dev' into dev

973a7df

zaloguj12 and others added 2 commits May 19, 2026 17:24

Merge branch 'OpenCloudGaming:dev' into dev

7abf6b9

fix review stuff

c01b914

further review fix

d7d9070

Merge branch 'dev' into dev

d59a310

Merge branch 'OpenCloudGaming:dev' into dev

fcae8d5

Kief5555 deleted the branch OpenCloudGaming:dev May 31, 2026 15:09

Kief5555 closed this May 31, 2026

Kief5555 reopened this May 31, 2026

Merge branch 'OpenCloudGaming:dev' into dev

30dc591

chatgpt-codex-connector Bot reviewed May 31, 2026

View reviewed changes

Comment thread native/opennow-streamer/src/gstreamer_platform.rs Outdated

Comment thread native/opennow-streamer/src/gstreamer_platform.rs Outdated

Comment thread opennow-stable/src/main/signaling/signalingCoordinator.ts

Fix native streamer shortcut capture

2d559f2

Made by codex

chatgpt-codex-connector Bot reviewed May 31, 2026

View reviewed changes

fix

0e0b925

Kief5555 requested a review from Copilot June 1, 2026 04:08

Copilot started reviewing on behalf of Kief5555 June 1, 2026 04:08 View session

Kief5555 requested review from Kief5555 and zortos293 June 1, 2026 04:08

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Comment thread opennow-stable/src/renderer/src/App.tsx Outdated

Fix native shortcut review feedback

c6143d6

Made by codex

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

capy-ai Bot reviewed Jun 1, 2026

View reviewed changes

Merge branch 'OpenCloudGaming:dev' into dev

8451dfb

zortos293 merged commit 2c4271a into OpenCloudGaming:dev Jun 4, 2026
6 checks passed

Uh oh!

Conversation

zaloguj12 commented May 16, 2026

Description

Verification

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

capy-ai Bot commented May 17, 2026

Uh oh!

zaloguj12 commented May 17, 2026

Uh oh!

zortos293 commented May 18, 2026

Uh oh!

zortos293 commented May 18, 2026

Uh oh!

zaloguj12 commented May 18, 2026

Uh oh!

zaloguj12 commented May 19, 2026

Uh oh!

zaloguj12 commented May 19, 2026

Uh oh!

zaloguj12 commented May 20, 2026

Uh oh!

Kief5555 commented May 31, 2026

Uh oh!

zaloguj12 commented May 31, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zaloguj12 commented May 31, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

zaloguj12 commented Jun 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

capy-ai Bot Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

capy-ai Bot Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

zortos293 commented Jun 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone