Conversation
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
New Crowdin updates
[ci skip]
…ndows, and macOS. (#464) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
New Crowdin updates
[ci skip]
New Crowdin updates
[ci skip]
New Crowdin updates
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
Add session time remaining feature to stats overlay
…opennow-stable/tmp-0.2.7 chore(deps-dev): bump tmp from 0.2.5 to 0.2.7 in /opennow-stable
…-fix Implement German keyboard layout support and clipboard functionality
|
Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6207f9f29d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "tagline": "Open-Source-Cloud-Gaming-Client", | ||
| "description": "Cloud-Gaming, Open Source.", |
There was a problem hiding this comment.
The /workspace/OpenNOW/AGENTS.md localization instructions say Crowdin owns generated translations and localized copy changes should edit only locales/en.json. This commit directly changes generated locale files (for example locales/de.json here, plus other non-English locales), so these manual translations can be overwritten or conflict with the next Crowdin sync; keep the source changes in en.json and let Crowdin regenerate the localized files.
Useful? React with 👍 / 👎.
| const sourceId = String(item.id ?? item.title ?? "unknown"); | ||
| const steamAppId = item.steamUrl?.split("/app/")[1]?.split("/")[0]; | ||
| const id = steamAppId || sourceId; |
There was a problem hiding this comment.
When a public-list entry has both NVIDIA's id and a Steam URL whose /app/ id differs, this replaces the launch/variant id with the Steam store id. handlePlayGame treats a numeric selected variant id as the GFN app id before calling resolveLaunchAppId, so public-only Steam games appended to catalog search will try to launch the Steam app id instead of NVIDIA's app id.
Useful? React with 👍 / 👎.
| if (pad.buttons[0]?.pressed) buttons |= 1 << 0; | ||
| if (pad.buttons[3]?.pressed) buttons |= 1 << 1; | ||
| if (pad.buttons[12]?.pressed || (pad.axes[1] ?? 0) < -0.65) buttons |= 1 << 2; | ||
| if (pad.buttons[13]?.pressed || (pad.axes[1] ?? 0) > 0.65) buttons |= 1 << 3; | ||
| if (pad.buttons[14]?.pressed || (pad.axes[0] ?? 0) < -0.65) buttons |= 1 << 4; | ||
| if (pad.buttons[15]?.pressed || (pad.axes[0] ?? 0) > 0.65) buttons |= 1 << 5; |
There was a problem hiding this comment.
In controller mode on the Home page, this gamepad polling only maps A/Y/D-pad/axes and never reads shoulder buttons 4/5 or calls the onPreviousControllerPage/onNextControllerPage callbacks (repo-wide search shows those props are only declared/passed). Since the previous global controller navigation was removed, a user navigating with only a gamepad has no way to switch between Home, Library, and Settings.
Useful? React with 👍 / 👎.
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
New Crowdin updates
|
@copilot resolve the merge conflicts in this pull request |
This pull request updates the GitHub Actions CI/CD workflow runner configurations to use custom "blacksmith" runners with more specific hardware allocations, and significantly expands localization strings for both English and Spanish. The localization changes add new UI labels, controller mode support, and error messages, while removing a now-redundant section. These updates improve both the build infrastructure and user interface internationalization.
Workflow runner changes:
runs-onfields in.github/workflows/auto-build.yml,.github/workflows/release.yml, and.github/workflows/codeql.ymlto use specificblacksmithrunners (e.g.,blacksmith-2vcpu-ubuntu-2404,blacksmith-6vcpu-macos-15, etc.) for more predictable and performant builds across Linux, macOS, and Windows targets. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Localization and UI enhancements:
locales/en.jsonandlocales/es.jsonfor controller mode, store/library filtering, game details, session time, and new error messages. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]controllerModesection fromlocales/en.jsonas its content was integrated into other sections.Minor improvements:
"buy"and"durationLeft"in both English and Spanish. [1] [2] [3]These changes ensure the application is ready for improved controller support, better error handling, and more robust, reliable CI/CD builds.