feat(timeline): implement track visibility toggle #681
+46
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix OpenCut-app#658: Add hidden property to TimelineTrack interface - Add toggleTrackVisibility function to timeline store - Update Eye button to toggle between Eye/EyeOff icons - Add visual feedback (opacity) for hidden tracks - EyeOff icon shown in red when track is hidden
|
@ThanhNguyxn is attempting to deploy a commit to the OpenCut OSS Team on Vercel. A member of the Team first needs to authorize it. |
👷 Deploy request for appcut pending review.Visit the deploys page to approve it
|
Contributor
📝 WalkthroughWalkthroughAdds per-track visibility: a new optional Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TimelineUI as Timeline UI
participant Store as Timeline Store
participant History as History Manager
participant Persist as Persist/Save
User->>TimelineUI: Click visibility button (trackId)
TimelineUI->>Store: toggleTrackVisibility(trackId)
Store->>Store: toggle track.hidden
Store->>History: pushHistory(change)
Store->>Persist: updateTracksAndSave(tracks)
Persist-->>Store: save acknowledged
Store-->>TimelineUI: updated state
TimelineUI-->>User: re-render showing Eye/EyeOff and opacity
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/web/src/components/editor/timeline/index.tsx`:
- Around line 793-803: The visibility toggle uses SVG icons (Eye / EyeOff) which
are not keyboard-focusable; wrap the icons in a focusable button element (or
your Button component) and move the onClick to that button, add an appropriate
aria-label (e.g., `aria-label={track.hidden ? "Show track" : "Hide track"}`) and
preserve the call to toggleTrackVisibility(track.id); ensure the button has no
disruptive styles (use className on the button for cursor/colour) so visual
appearance is unchanged and keyboard users can activate the control.
- Address CodeRabbit feedback for keyboard accessibility - Wrap mute and visibility toggle icons in button elements - Add aria-labels for screen readers - Add focus ring styles for keyboard navigation
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/web/src/components/editor/timeline/index.tsx`:
- Around line 782-805: Add <title> child elements to each Lucide icon instance
to satisfy SVG accessibility guidelines: for the icons VolumeOff, Volume2, Eye,
and EyeOff used inside the buttons that call toggleTrackMute(track.id) and
toggleTrackVisibility(track.id), render a <title> with a concise label matching
the button aria-label (e.g., "Mute track" / "Unmute track" for Volume icons and
"Hide track" / "Show track" for Eye icons). Ensure each icon receives the
correct title based on the track.muted and track.hidden boolean states so the
SVGs have accessible titles that align with the existing aria-labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the missing track visibility toggle functionality on the timeline.
Fixes #658 - Non-functional Eye Button on Timeline Track
Problem:
Solution:
Added
hiddenproperty to TimelineTrack interface (types/timeline.ts)hidden?: booleanpropertyAdded
toggleTrackVisibilityfunction (stores/timeline-store.ts)toggleTrackMutefunctionUpdated Eye button in timeline UI (
components/editor/timeline/index.tsx)EyeOffimport from lucide-reactcursor-pointerclass for better UXtext-destructive) when track is hiddenAdded visual feedback for hidden tracks (
components/editor/timeline/timeline-track.tsx)opacity-40)Visual Changes
Testing
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.