Skip to content

Flush TLB at EL1 using tbli vmalle1 - #236

Merged
kuqin12 merged 2 commits into
OpenDevicePartnership:mainfrom
kuqin12:flush_tlb
Sep 19, 2026
Merged

kuqin12 merged 2 commits into
OpenDevicePartnership:mainfrom
kuqin12:flush_tlb

Conversation

@kuqin12

@kuqin12 kuqin12 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Description

According to ARM reference manual section C5.5.1 TLBI ALLE1, TLBI ALLE1NXS, TLB Invalidate All, EL1, tlbi alle1 at EL1 will do either EL2 trapping or undefined, which is not what this usage is meant to be.

Changing to vmalle1 to actually perform the operation at EL1. This also matches the implementation of EL1 branch of ArmInvalidateTlb and ArmEnableMmu in edk2.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

This was tested on KVM enabled QEMU and no longer crashes the system.

Integration Instructions

N/A

@kuqin12
kuqin12 requested review from joschock and os-d September 18, 2026 20:56
@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@kuqin12
kuqin12 requested a review from cfernald September 18, 2026 21:08
@kuqin12 kuqin12 added the bug Something isn't working label Sep 18, 2026
@kuqin12
kuqin12 merged commit 6f45ac2 into OpenDevicePartnership:main Sep 19, 2026
7 checks passed
@kuqin12
kuqin12 deleted the flush_tlb branch September 19, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants