-
Notifications
You must be signed in to change notification settings - Fork 18
Feature/1355 docs overview #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
|
Hey @jackohilts , Could you Kindly review this PR and let us know if any changes are needed? |
mercy-ship-it
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hunterachieng You can include the Overview section for the following adaptor as they are missing in the updates
- eapts
- formsg
- memento
- motherduck
- ona
- postgresql
https://docs.google.com/spreadsheets/d/11cfg8dRQTOYBk27S5KUFoJEKWSYLAKzU-oYQffZboXo/edit?gid=0#gid=0
Signed-off-by: Hunter Achieng <[email protected]>
jackohilts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey I've read through the edits and I think these are all good additions, but I don't think it quite meets the Acceptance Criteria of the original 1355 Issue saying that "Every Adaptor has a compelling Overview section which explains the value and functionality of each Adaptor, and how it might be used within solution designs to provide value to users of OpenFn."
I think this PR should still be merged, but we shouldn't close the issue just yet as we don't have good Overview Sections for all Adaptors.
One small edit I would make to the script is that add-help-section.js script doesn't check if help section already exists (which might cause duplicates if it's run twice...). Might make sense to incorporate that in a next PR if we are to automate more of this content generation.
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
adaptors/asana.md
Outdated
|
|
||
| ### I've noticed a problem with this Adaptor, or something is out of date, what can I do? | ||
|
|
||
| Thanks for asking! We are a fully Open Source Digital Public Good, and we welcome contributions from our community. Check out our [Adaptors Wiki](https://github.com/OpenFn/adaptors/wiki) for more information on how you can update Adaptors! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most information has moved to the wiki folder in the repo now. Can we link to that instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we must have a better landing page for contributions? If not we should really think about investing in something @jackohilts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting @josephjclark - can you share a link to where those instructions are? Right now I take Product Team's lead on the best guidance for crowding in contributions, but I totally agree that we should invest in some clear guidance on that (starting, probably, with aligning on the process we want the big wide world to follow).
What is the best thing we have right now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah classic problem of no-one owning the docs properly (and everyone having opinions)
@hunterachieng for now can you update the link to https://github.com/OpenFn/adaptors/blob/main/wiki/index.md for now
Jack and I will work out a better landing route later. But if we get that link fixed I think we can merge this for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josephjclark I have fixed the links
Signed-off-by: Hunter Achieng <[email protected]>
Short Description
Add overview docs for all adaptors without this section
Closes #1355
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy