Skip to content

remove perses atommapper and scorer#1943

Draft
atravitz wants to merge 2 commits intomainfrom
remove_perses
Draft

remove perses atommapper and scorer#1943
atravitz wants to merge 2 commits intomainfrom
remove_perses

Conversation

@atravitz
Copy link
Copy Markdown
Contributor

@atravitz atravitz commented Apr 16, 2026

resolves #1635

We communicated to the board that we will be removing these in v1.11.0. My only concern is that I originally said v2.0 in the changelog.

To be thorough, we can give this one more deprecation cycle where we update the changelog to say "will be removed in v1.12.0" so that users have appropriate heads-up.

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.63%. Comparing base (528a597) to head (ed1a016).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1943      +/-   ##
==========================================
- Coverage   94.72%   90.63%   -4.10%     
==========================================
  Files         208      206       -2     
  Lines       18779    18634     -145     
==========================================
- Hits        17789    16888     -901     
- Misses        990     1746     +756     
Flag Coverage Δ
fast-tests 90.63% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

No API break detected ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vendor needed perses code (or remove)

1 participant