Skip to content

Switch repeat id assignment from leg to repeat in AFE Protocols#1948

Open
IAlibay wants to merge 4 commits intomainfrom
afe_uuid_fix
Open

Switch repeat id assignment from leg to repeat in AFE Protocols#1948
IAlibay wants to merge 4 commits intomainfrom
afe_uuid_fix

Conversation

@IAlibay
Copy link
Copy Markdown
Member

@IAlibay IAlibay commented Apr 20, 2026

This PR changes things so that a single uuid is used for each repeat in a Protocol, rather than each leg. This more strictly adheres to the idea of being a "repeat_id". It is also more intuitive since it allows us to assume that the uuid represents a single DAG execution.

We may have to revisit this formalism if/when we have a case where we have multiple indentical units being executed in a single DAG.

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@IAlibay IAlibay requested a review from atravitz April 20, 2026 08:21
@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Apr 20, 2026

pre-commit.ci autofix

@IAlibay IAlibay changed the title Switch uuid from leg to repeat in AFE Protocols Switch repeat uuid assignment from leg to repeat in AFE Protocols Apr 20, 2026
@IAlibay IAlibay changed the title Switch repeat uuid assignment from leg to repeat in AFE Protocols Switch repeat id assignment from leg to repeat in AFE Protocols Apr 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.91%. Comparing base (fc6689e) to head (097595a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1948      +/-   ##
==========================================
- Coverage   94.28%   89.91%   -4.38%     
==========================================
  Files         214      215       +1     
  Lines       19000    19266     +266     
==========================================
- Hits        17915    17323     -592     
- Misses       1085     1943     +858     
Flag Coverage Δ
fast-tests 89.91% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IAlibay IAlibay added this to the 1.11.0 milestone Apr 24, 2026
@github-actions
Copy link
Copy Markdown

No API break detected ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants