Switch repeat id assignment from leg to repeat in AFE Protocols#1948
Open
Switch repeat id assignment from leg to repeat in AFE Protocols#1948
Conversation
Member
Author
|
pre-commit.ci autofix |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1948 +/- ##
==========================================
- Coverage 94.28% 89.91% -4.38%
==========================================
Files 214 215 +1
Lines 19000 19266 +266
==========================================
- Hits 17915 17323 -592
- Misses 1085 1943 +858
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No API break detected ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes things so that a single uuid is used for each repeat in a Protocol, rather than each leg. This more strictly adheres to the idea of being a "repeat_id". It is also more intuitive since it allows us to assume that the uuid represents a single DAG execution.
We may have to revisit this formalism if/when we have a case where we have multiple indentical units being executed in a single DAG.
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin