Skip to content

fan curves: don't factory-reset via pwmN_enable=3 when reading defaults (fixes asusd start hang + input freeze on TUF FX608JMR) #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aminezzy wants to merge 1 commit into from
+5 −7
Closed

fan curves: don't factory-reset via pwmN_enable=3 when reading defaults (fixes asusd start hang + input freeze on TUF FX608JMR) #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions rog-profiles/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,13 +157,11 @@ impl FanCurveProfiles {
profile: PlatformProfile,
device: &mut Device,
) -> Result<(), ProfileError> {
let fans = Self::supported_fans()?;
// Do reset for all
for fan in fans {
let pwm_num: char = fan.into();
let pwm = format!("pwm{pwm_num}_enable");
device.set_attribute_value(&pwm, "3")?;
}
// Writing "3" to pwm<N>_enable makes the kernel re-fetch factory
// defaults via the fan_curve_get_factory_default WMI call. On some
// boards (TUF FX608JMR, BIOS 306) that call blocks ~30s, stalls the EC
// (input freezes) and returns EIO, so read the curves the driver
// already reports instead of resetting first.
self.read_from_dev_profile(profile, device)?;
Ok(())
}
Expand Down