Recast characterization tests - #4
Open
OursCodeur wants to merge 2 commits into
Open
Conversation
OursCodeur
marked this pull request as ready for review
August 18, 2026 21:08
OursCodeur
force-pushed
the
split/recast-characterization-tests
branch
from
August 19, 2026 12:07
e4b6cda to
6cda540
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5 changes how rasterization and the ledge filter are implemented. Before that lands I'd like the behaviour they have today written down as tests, so that "the output didn't change" is something you can check rather than something I assert.
These tests accept
openmw-fixesas it is. They're not written to fail the current implementation anywhere, and if one of them fails after #5 then #5 is wrong.Rasterization is checked against an independent path : generic polygon clipping plus repeated single-triangle insertion, which reaches the same spans through code that shares nothing with the bulk overloads. The matrix covers every bulk overload, area and merge behaviour, the grid and heightfield boundaries, triangles that land in a single voxel, arrival order between spans that touch, and a heightfield that already had spans in it before the call.
rcFilterLedgeSpansis checked against a linked-list reference scan over deterministic multi-span columns, built so neighbours differ in the ways the filter actually branches on.openmw-fixesat03259f3The assertion count is large because each case compares the complete span stream over a generated matrix of inputs, not because the same trivial check is repeated. If that ratio bothers you I can collapse the matrices, it just costs coverage of the boundary cases.
3 test files, +540/−1, no production file touched. #5 depends on this, but this one stands on its own and can be read without agreeing to anything in #5.
Tests 3/3 green on Linux, macOS and Windows. Build is 14/18 with the four VS2019 jobs queued on unavailable runners, which is what #3 is about.