Skip to content

Fix: Avoid buffer overflow when requesting the net path segment. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sherholz wants to merge 3 commits into from
Closed

Fix: Avoid buffer overflow when requesting the net path segment. #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab4ebb7
[superbuild] Forcing TBB build from source on APPLE
sherholz May 31, 2026
c681226
[field] Fixing wrong initial upper bound for the scene bound
sherholz May 31, 2026
aa10e9d
[segment] Fixing overflow bug when requesting a new path segment that…
sherholz Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions openpgl/data/PathSegmentDataStorage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ struct PathSegmentDataStorage
PathSegmentData *next()
{
#if defined(OPENPGL_PATHSEGMENT_STORAGE_USE_ARRAY)
if (m_seg_idx + 1 <= m_max_seg_size)
if (m_seg_idx + 1 < m_max_seg_size)
{
m_seg_idx++;
m_segmentStorage[m_seg_idx] = PathSegmentData();
Expand All @@ -146,7 +146,7 @@ struct PathSegmentDataStorage
void addSegment(const PGLPathSegmentData &segment)
{
#if defined(OPENPGL_PATHSEGMENT_STORAGE_USE_ARRAY)
if (m_seg_idx + 1 <= m_max_seg_size)
if (m_seg_idx + 1 < m_max_seg_size)
{
m_seg_idx++;
m_segmentStorage[m_seg_idx] = segment;
Expand All @@ -159,7 +159,7 @@ struct PathSegmentDataStorage
void push_back(const PathSegmentData &psData)
{
#if defined(OPENPGL_PATHSEGMENT_STORAGE_USE_ARRAY)
if (m_seg_idx + 1 <= m_max_seg_size)
if (m_seg_idx + 1 < m_max_seg_size)
{
m_seg_idx++;
m_segmentStorage[m_seg_idx] = psData;
Expand Down
2 changes: 1 addition & 1 deletion openpgl/field/Field.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ struct Field
void estimateSceneBounds(const SampleContainerInternal &samples)
{
m_sceneBounds.lower = Vector3(std::numeric_limits<float>::max());
m_sceneBounds.upper = Vector3(std::numeric_limits<float>::min());
m_sceneBounds.upper = Vector3(-std::numeric_limits<float>::max());
m_isSceneBoundsSet = false;

if (samples.size() > 0)
Expand Down
3 changes: 3 additions & 0 deletions superbuild/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ option(DOWNLOAD_ISPC "Download ISPC or use the one found in the system environme

if (BUILD_TBB)
set(TBB_VERSION "2021.13.0" CACHE STRING "TBB version to download")
if(APPLE)
set(BUILD_TBB_FROM_SOURCE ON)
endif()
if (BUILD_TBB_FROM_SOURCE)
if (TBB_VERSION VERSION_LESS 2021)
message(FATAL_ERROR "Only TBB 2021 and later are supported when building TBB from source")
Expand Down
Loading