Skip to content

Plan level vid#234

Merged
tenkus47 merged 6 commits into
devfrom
plan-level-vid
Jun 30, 2026
Merged

Plan level vid#234
tenkus47 merged 6 commits into
devfrom
plan-level-vid

Conversation

@Tech-lo

@Tech-lo Tech-lo commented Jun 29, 2026

Copy link
Copy Markdown
Member

add video on plan and pre existing tests

@Tech-lo Tech-lo requested a review from tenkus47 June 29, 2026 12:40
@greptile-apps

greptile-apps Bot commented Jun 29, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Reviews (3): Last reviewed commit: "lint" | Re-trigger Greptile

Comment thread src/components/routes/create-plan/CreatePlan.tsx
Comment thread src/components/routes/create-plan/PlanVideosSection.tsx Outdated
Comment thread src/components/routes/profile/Profile.test.tsx
Comment thread src/components/routes/task/components/view/TaskForm.test.tsx
Comment on lines +55 to +56

useEffect(() => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Details Cache Stays Stale This refreshes only the new ['plan-videos', planId] query after plan-level video changes. The plan details page still uses its plan details cache for the same plan resource, so after a user adds, removes, or reorders videos here, navigating back to a cached details page can show the old video list until another refetch happens. Please also refresh or update the plan details cache for this plan when these mutations succeed.

@tenkus47 tenkus47 merged commit 496ef33 into dev Jun 30, 2026
3 checks passed
@tenkus47 tenkus47 deleted the plan-level-vid branch June 30, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants