refactor: replace _SessionCard with PracticeChantListTile for improve…#488
Merged
Conversation
…d UI consistency and functionality
Contributor
Confidence Score: 4/5Safe to merge; the refactor is mechanical and the shared widget is already in use across other screens with no new logic paths introduced. Both changed files are straightforward: the widget gains opt-in flags with backward-compatible defaults, and the screen swaps an inline card for the shared widget. The only worth-noting side effect is the description text truncating at 2 lines instead of 3 in the chants tab — whether intentional or accidental, it is worth a quick check before landing. practice_chant_list_tile.dart — verify the maxLines: 2 cap for description text is the intended behaviour for the chants session-picker context. Reviews (1): Last reviewed commit: "refactor: replace _SessionCard with Prac..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d UI consistency and functionality