Skip to content

feat: Progressbar and group name and image at series card#492

Merged
tentamdin merged 3 commits into
developfrom
progressbar
Jul 3, 2026
Merged

feat: Progressbar and group name and image at series card#492
tentamdin merged 3 commits into
developfrom
progressbar

Conversation

@TenzDelek

@TenzDelek TenzDelek commented Jul 3, 2026

Copy link
Copy Markdown
Member
Screenshot 2026-07-03 at 6 11 41 PM Screenshot 2026-07-03 at 6 11 58 PM Screenshot 2026-07-03 at 6 12 36 PM

@TenzDelek TenzDelek requested a review from tentamdin July 3, 2026 12:43
@greptile-apps

greptile-apps Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge; changes are well-scoped to display logic and data parsing with no impact on write paths or auth flows.

The data-layer changes (entity fields, model parsing, cache versioning, optional auth forwarding) are additive and backward-compatible. The widget refactoring replaces inline duplicates with shared components without altering any navigation, state-mutation, or enrollment logic. The two findings are style-level observations with no runtime impact.

No files require special attention.

Reviews (2): Last reviewed commit: "Update lib/features/home/presentation/wi..." | Re-trigger Greptile

Comment thread lib/features/home/presentation/widgets/plan_list_view.dart Outdated
String featuredSeriesKey(String language, int limit) =>
'featured_series:$language:$limit';
'featured_series:v3:$language:$limit';
String seriesListKey(String language) => 'series_list:$language';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 seriesListKey was not given a version suffix, unlike featuredSeriesKey (→ v3) and seriesByIdKey (→ v2). The same staleness issue applies: a device with a series_list:$language entry from before auth was wired to the endpoint will serve the cached models (missing progressJson/partnerJson) on the initial render, so the progress bar and partner row won't appear until the background refresh completes. Adding a version token (e.g. 'series_list:v2:$language') would invalidate those entries on first launch.

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@tentamdin tentamdin merged commit 8554a8d into develop Jul 3, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants