Skip to content

feat: add adaptive launcher icons and background color for improved a…#494

Closed
ta4tsering wants to merge 1 commit into
developfrom
fix-andriod-logo
Closed

feat: add adaptive launcher icons and background color for improved a…#494
ta4tsering wants to merge 1 commit into
developfrom
fix-andriod-logo

Conversation

@ta4tsering

Copy link
Copy Markdown
Contributor

…pp branding

@greptile-apps

greptile-apps Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

Safe to merge — the icon assets and XML are wired up correctly and the jni cleanup is accurate. The only fragile point is that the manually added <inset> in launcher_icon.xml would be silently dropped if the icon generator is re-run in the future.

The changes are straightforward branding assets and XML configuration. All resource references (@color/ic_launcher_background, @drawable/ic_launcher_foreground, @mipmap/launcher_icon) resolve correctly. The main maintenance concern is that the hand-edited launcher_icon.xml (with its 16% inset) is not preserved by flutter_launcher_icons, so a future re-generation run would silently remove the padding.

android/app/src/main/res/mipmap-anydpi-v26/launcher_icon.xml — the manual inset should be documented so it is not lost on the next icon regeneration run.

Reviews (1): Last reviewed commit: "feat: add adaptive launcher icons and ba..." | Re-trigger Greptile

Comment on lines +4 to +8
<foreground>
<inset
android:drawable="@drawable/ic_launcher_foreground"
android:inset="16%" />
</foreground>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Manual inset will be lost on next icon regeneration

The <inset android:inset="16%"> wrapper was added manually to pad the foreground inside the safe zone, but flutter_launcher_icons generates this file without an inset. Re-running flutter pub run flutter_launcher_icons:main (e.g. after a future icon change) will overwrite launcher_icon.xml with a flat <foreground android:drawable="@drawable/ic_launcher_foreground"/>, silently dropping the padding. Consider adding a comment in pubspec.yaml or the project docs noting that this file must be manually restored after regeneration.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment on lines +3 to +4
<color name="ic_launcher_background">#FFFFFF</color>
</resources> No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The file is missing a newline at the end, which can cause spurious diffs and warnings in some XML tooling.

Suggested change
<color name="ic_launcher_background">#FFFFFF</color>
</resources>
<color name="ic_launcher_background">#FFFFFF</color>
</resources>

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@tentamdin tentamdin closed this Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants