feat: add adaptive launcher icons and background color for improved a…#494
feat: add adaptive launcher icons and background color for improved a…#494ta4tsering wants to merge 1 commit into
Conversation
Confidence Score: 4/5Safe to merge — the icon assets and XML are wired up correctly and the The changes are straightforward branding assets and XML configuration. All resource references (
Reviews (1): Last reviewed commit: "feat: add adaptive launcher icons and ba..." | Re-trigger Greptile |
| <foreground> | ||
| <inset | ||
| android:drawable="@drawable/ic_launcher_foreground" | ||
| android:inset="16%" /> | ||
| </foreground> |
There was a problem hiding this comment.
Manual inset will be lost on next icon regeneration
The <inset android:inset="16%"> wrapper was added manually to pad the foreground inside the safe zone, but flutter_launcher_icons generates this file without an inset. Re-running flutter pub run flutter_launcher_icons:main (e.g. after a future icon change) will overwrite launcher_icon.xml with a flat <foreground android:drawable="@drawable/ic_launcher_foreground"/>, silently dropping the padding. Consider adding a comment in pubspec.yaml or the project docs noting that this file must be manually restored after regeneration.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| <color name="ic_launcher_background">#FFFFFF</color> | ||
| </resources> No newline at end of file |
There was a problem hiding this comment.
The file is missing a newline at the end, which can cause spurious diffs and warnings in some XML tooling.
| <color name="ic_launcher_background">#FFFFFF</color> | |
| </resources> | |
| <color name="ic_launcher_background">#FFFFFF</color> | |
| </resources> |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
…pp branding