Security fix: isolate health checks from admin API rate-limit bucket - #126
Draft
cursor[bot] wants to merge 2 commits into
Draft
Security fix: isolate health checks from admin API rate-limit bucket#126cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Public GET /api/v1/health shared the authenticated /api/* rate-limit bucket, so unauthenticated health probes could exhaust the admin API budget for the same client IP and deny stream management requests. Co-authored-by: Alexander Wagner <info@alexanderwagnerdev.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security review finding (Medium)
Issue: #125
Location:
src/rate_limit.rsImpact: Unauthenticated
GET /api/v1/healthshared the authenticated/api/*rate-limit bucket ({client_ip}:api). A remote attacker on the same source IP (NAT, reverse proxy, or co-located monitoring) could exhaust the 120/min default budget and block legitimate admin API calls (POST/DELETE /api/v1/streams, etc.) with429until the window resets.Attack path:
rate_limit::middlewareruns before auth; all/api/*paths map to theapibucketFix
Classify
/api/v1/healthinto a separatehealthbucket usingdefault_max, so orchestrator probes no longer consume the authenticated admin API budget.Tests
rate_limit::tests::health_uses_separate_bucket_from_authenticated_apihttp::tests::health_rate_limit_does_not_exhaust_authenticated_api_budgetapi_rate_limit_returns_429_when_exceededto target protected routesAll 110 unit tests pass.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.