import: handle importing old files with numberOfStops #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anisometropie
force-pushed
the
vcs/import-old-files
branch
from
f69b61d to
a8500c5
Compare
emersion
reviewed
Nov 4, 2025
Member
emersion
left a comment
emersion
left a comment
There was a problem hiding this comment.
Thanks for the patch! Overall looks good, just a few comments below.
clarani
reviewed
Nov 4, 2025
clarani
left a comment
clarani
left a comment
There was a problem hiding this comment.
Nice work, LGTM overall, but I'm not a specialist of this codebase :)
emersion
merged commit 435f1c6
into
mrd/new-nodes-management-system
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in the migration #538,
numberOfStopsis removed from the model. The PR allows to to import old files still containings it.During
loadNetzgrafikDto, we now replace numberOfStops with actual nodes in the graph.closes #592
closes OpenRailAssociation/osrd#13286
some unit tests likely to fail until the whole migration is done
Issues
#592
Checklist
documentation/