Open
Conversation
- Introduced `DeleteMessageByRelatedFloorID` and `DeleteMessageByRelatedHoleID` methods to handle message deletions based on related floor or hole IDs.
- Introduced `RelatedFloorID` and `RelatedHoleID` fields to the `Notification` model to improve context in messages. - Updated apis in `report` and `penalty` to populate these fields when creating notifications. - Enhanced sensitive content and modification notifications with related IDs for better traceability. - Improved message construction consistency across `floor` operations.
- Added calls to `DeleteMessageByRelatedHoleID` and `DeleteMessageByRelatedFloorID` in hole and floor deletion logic. - Ensured proper error handling during message deletion for associated content. - Tidied up code formatting in affected areas for better readability.
Acture
requested review from
JingYiJun and
ppolariss
and removed request for
ppolariss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature involves modifications across three main components: the Notification/Message service, the Hole service, and the Floor service. Closes #171.
Introduced new methods to the message deletion logic:
DeleteMessageByRelatedFloorID(ID)DeleteMessageByRelatedHoleID(ID)The Notification model is extended to explicitly store the source content IDs (e.g., related_hole_id, related_floor_id).
Integration points were added to the business logic of Hole and Floor deletion/restriction operations.
Triggers: The notification deletion request is now sent when content meets any of the following criteria:
Not sure if this is what was requested. Not tested due to the lack of data.