Skip to content

Make opening URLs not fatal if a web browser cannot be opened from the terminal #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nelsonjchen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make opening URLs not fatal if a web browser cannot be opened from the terminal #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61b3b87
Make opening URLs not fatal if a web browser cannot be opened from th…
nelsonjchen Jan 30, 2021
d257461
Update CHANGELOG.md
nelsonjchen Jan 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

- Fix bug causing prompts to repeatedly echo input of large strings
- dce leases end command can now accept leaseID
- Print out browser URL to be copied and opened in case opening the browser from the Terminal fails such as out of the box on WSL2.

## v0.5.0

Expand Down
3 changes: 2 additions & 1 deletion internal/util/web.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ type WebUtil struct {

func (w *WebUtil) OpenURL(url string) {
if err := browser.OpenURL(url); err != nil {
log.Fatalln("Error opening web browser", err)
log.Errorln("Error opening web browser", err)
log.Infoln("Please copy and visit the following URL in your browser:", url)
}
}

Expand Down