Skip to content

[#1137] [#1138] [#1139] Update of control-item based components #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

[#1137] [#1138] [#1139] Update of control-item based components #1168

wants to merge 10 commits into from

Conversation

@pylapp
Copy link
Member

@pylapp pylapp commented Nov 18, 2025 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#1137
#1138
#1139

Description

  • For checkbox, switch and radio components: add read-only variant
  • For checkbox item, switch item, radio item: change "helper" parameter for "description"
  • For radio item change: change "additional" parameter for "extra"
  • For checkbox item, radio item, switch items, use another token for error container
  • Fix some a11y issues with bad vocalizations of errors
  • Change padding for control item content
  • Use last tokens library

Motivation & Context

Types of change

  • Refactoring (non-breaking change)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design review has been done
  • Accessibility review has been done
  • Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@pylapp pylapp requested a review from ludovic35 as a code owner November 18, 2025 12:05
This was linked to issues Nov 18, 2025
[Component Update] Checkbox v2.4.0 #1137
Open
[Component Update] Switch v1.5.0 #1138
Open
[Component Update] Radio button v1.4.0 #1139
Open
@pylapp
Copy link
Member Author

pylapp commented Nov 18, 2025 •
edited
Loading

@ludovic35 Message de commit

refactor: components with read only variants and update parameters of control items (#1137) (#1138) (#1138) (#1168)

Note

Merger ensuite la PR de l'app de démo Orange-OpenSource/ouds-ios-design-system-toolbox#138

@pylapp pylapp mentioned this pull request Nov 18, 2025
Open
16 tasks
pylapp added 10 commits November 18, 2025 17:04
@pylapp
feat: add read only variant for checkbox and `checkbox indetermin…
9f3c5ec 
…ate` components (#1137)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor: padding token for error containers (#1137)
0539da8 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: update a11y label, component versions, and signature / API for…
354e265 
… helper text (#1137)

- A11Y label improved to use read only state
- Fix issue with hint in error case
- Rename old helper text to descrption
- Update signatures

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix: padding for control item content
9ec3ba4 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: update changelog and versions
21ab765 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
feat: add read only variant for switch only component (#1138)
b8a1c62 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
feat: add read only variant for radio only component (#1139)
2cba7d7 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix: error message vocalization for radio item
0b66f56 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor: additional label now extra label for control item (#1139)
7523b45 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: clean up
100f22b 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp force-pushed the refactor/update-control-items branch from a6c48d8 to 100f22b Compare November 18, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ludovic35 ludovic35 Awaiting requested review from ludovic35 ludovic35 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ludovic35 ludovic35

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Component Update] Radio button v1.4.0 [Component Update] Switch v1.5.0 [Component Update] Checkbox v2.4.0

2 participants

@pylapp @ludovic35