Skip to content

fix(WPF): deny WPF Behaviors namespaces in untrusted homepage XAML #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lhx077 wants to merge 1 commit into
base: dev
Choose a base branch
from
+14 −0
Open

fix(WPF): deny WPF Behaviors namespaces in untrusted homepage XAML #3049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Plain Craft Launcher 2/Modules/Base/ModBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3213,6 +3213,20 @@ public static object GetObjectFromXML(string str)
Replace("EventData=\"", "local:CustomEventService.EventData=\"").
Replace("Property=\"EventType\"", "Property=\"local:CustomEventService.EventType\"").
Replace("Property=\"EventData\"", "Property=\"local:CustomEventService.EventData\"");

// 自定义主页 XAML 被视为不受信任内容；禁止引用 WPF Behaviors 中可调用方法/改写属性的通用动作。
foreach (var blockedXamlNamespace in new[]

@whitecat346 whitecat346 Jun 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think u can make a static readonly array

{
"Microsoft.Xaml.Behaviors",
"Microsoft.Xaml.Behaviors.Core",
"Microsoft.Xaml.Interactions.Core",
"http://schemas.microsoft.com/xaml/behaviors"
})
{
if (str.Contains(blockedXamlNamespace, StringComparison.OrdinalIgnoreCase))
throw new UnauthorizedAccessException($"不允许使用 {blockedXamlNamespace} 命名空间。");
}

using (var stream = new MemoryStream(Encoding.UTF8.GetBytes(str)))
{
// 类型检查
Expand Down
Loading