feat(launch): 添加禁用自动崩溃分析的设置项#3077
Merged
Merged
Conversation
审阅者指南(在小型 PR 上折叠)审阅者指南为启动器添加一个可配置选项,用于禁用自动崩溃分析,通过配置、UI 和崩溃处理逻辑进行串联,并对新设置标签进行本地化。 带有可选崩溃分析的崩溃处理时序图sequenceDiagram
participant GameProcess
participant ModWatcher
participant Config
participant ModBase
GameProcess ->> ModWatcher: Crashed
ModWatcher ->> ModWatcher: Crashed
ModWatcher ->> ModWatcher: WatcherLog
ModWatcher ->> ModMain: Hint
ModWatcher ->> Config: Launch.DisableCrashAnalysis
alt [DisableCrashAnalysis]
ModWatcher -->> ModBase: [skip FeedbackInfo]
else [!DisableCrashAnalysis]
ModWatcher ->> ModBase: FeedbackInfo
ModWatcher ->> ModBase: RunInNewThread
ModBase ->> ModBase: [perform crash analysis]
end
文件级变更
提示与命令与 Sourcery 交互
自定义你的体验访问你的 仪表盘 以:
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a configurable option to disable automatic crash analysis in the launcher, wires it through configuration, UI, and crash handling logic, and localizes the new setting label. Sequence diagram for crash handling with optional crash analysissequenceDiagram
participant GameProcess
participant ModWatcher
participant Config
participant ModBase
GameProcess ->> ModWatcher: Crashed
ModWatcher ->> ModWatcher: Crashed
ModWatcher ->> ModWatcher: WatcherLog
ModWatcher ->> ModMain: Hint
ModWatcher ->> Config: Launch.DisableCrashAnalysis
alt [DisableCrashAnalysis]
ModWatcher -->> ModBase: [skip FeedbackInfo]
else [!DisableCrashAnalysis]
ModWatcher ->> ModBase: FeedbackInfo
ModWatcher ->> ModBase: RunInNewThread
ModBase ->> ModBase: [perform crash analysis]
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - 我在这里给出一些整体性的反馈:
- 在
ModWatcher.Crashed中,当DisableCrashAnalysis为 true 时,前面的return会跳过后续所有逻辑;如果将来在FeedbackInfo之后再加入与崩溃分析无关的逻辑,建议只对崩溃分析相关的调用做条件判断,而不是直接退出整个方法。 - 新增的
DisableCrashAnalysis配置项显式使用了ConfigSource.Local,而附近其他 launch-advanced 选项并未指定来源;请确认这是有意为之,并且与你期望这些设置的存储和覆盖方式保持一致。
面向 AI 代理的提示
Please address the comments from this code review:
## Overall Comments
- In `ModWatcher.Crashed`, the early `return` when `DisableCrashAnalysis` is true skips all subsequent logic; if future non-analysis work is added after `FeedbackInfo`, consider guarding only the crash-analysis-specific calls instead of exiting the whole method.
- The new `DisableCrashAnalysis` config item explicitly uses `ConfigSource.Local` while other nearby launch-advanced options do not specify a source; confirm this is intentional and consistent with how you expect these settings to be stored and overridden.帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据这些反馈改进后续的评审。
Original comment in English
Hey - I've left some high level feedback:
- In
ModWatcher.Crashed, the earlyreturnwhenDisableCrashAnalysisis true skips all subsequent logic; if future non-analysis work is added afterFeedbackInfo, consider guarding only the crash-analysis-specific calls instead of exiting the whole method. - The new
DisableCrashAnalysisconfig item explicitly usesConfigSource.Localwhile other nearby launch-advanced options do not specify a source; confirm this is intentional and consistent with how you expect these settings to be stored and overridden.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `ModWatcher.Crashed`, the early `return` when `DisableCrashAnalysis` is true skips all subsequent logic; if future non-analysis work is added after `FeedbackInfo`, consider guarding only the crash-analysis-specific calls instead of exiting the whole method.
- The new `DisableCrashAnalysis` config item explicitly uses `ConfigSource.Local` while other nearby launch-advanced options do not specify a source; confirm this is intentional and consistent with how you expect these settings to be stored and overridden.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Chiloven945
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
在 Minecraft 启动期间新增一个可配置选项,用于禁用自动崩溃分析,并将其接入启动器设置界面和崩溃监视逻辑。
新功能:
LaunchAdvanceDisableCrashAnalysis,用于控制是否启用自动崩溃分析。Original summary in English
Summary by Sourcery
Add a configurable option to disable automatic crash analysis during Minecraft launch and wire it into the launcher settings UI and crash watcher logic.
New Features: