Skip to content

chore: 不打包accountsx模组配置#3078

Merged
LuLu-ling merged 1 commit into
PCL-Community:devfrom
Chengxidaxia:dev
Jun 8, 2026
Merged

chore: 不打包accountsx模组配置#3078
LuLu-ling merged 1 commit into
PCL-Community:devfrom
Chengxidaxia:dev

Conversation

@Chengxidaxia

@Chengxidaxia Chengxidaxia commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

由于accountsx模组明文存储账号Token,不打包 "config/accountsx/" 可防止账号被盗

Summary by Sourcery

构建:

  • 更新实例导出打包规则,为了安全起见省略 config/accountsx/ 目录。
Original summary in English

Summary by Sourcery

Build:

  • Update instance export packaging rules to omit the config/accountsx/ directory for security.

由于accountsx模组明文存储账号Token,不打包config/accountsx/可防止账号被盗
@pcl-ce-automation pcl-ce-automation Bot added 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 size: XS PR 大小评估:微型 labels Jun 8, 2026
@sourcery-ai

sourcery-ai Bot commented Jun 8, 2026

Copy link
Copy Markdown
审阅者指南(在小型 PR 上折叠)

审阅者指南

config/accountsx/ 目录从实例导出打包工作流中排除,以避免从 accountsx 模块中打包明文账号令牌。

文件级变更

变更 详情 文件
调整实例导出行为,使 config/accountsx/ 不再包含在已导出/已打包的实例中。
  • 修改 PageInstance 导出 XAML 逻辑或绑定的命令参数,在构建导出负载时跳过 config/accountsx/ 目录。
  • 确保在省略敏感的 accountsx 配置的前提下,导出 UI/行为对所有其他配置路径仍与之前保持一致。
Plain Craft Launcher 2/Pages/PageInstance/PageInstanceExport.xaml

提示与命令

与 Sourcery 交互

  • 触发新审阅: 在 pull request 中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审阅评论。
  • 从审阅评论生成 GitHub issue: 通过回复审阅评论让 Sourcery 从该评论创建一个 issue。你也可以在审阅评论下回复 @sourcery-ai issue 来从该评论创建 issue。
  • 生成 pull request 标题: 在 pull request 标题的任意位置写上 @sourcery-ai 即可随时生成标题。你也可以在 pull request 中评论 @sourcery-ai title 来(重新)生成标题。
  • 生成 pull request 摘要: 在 pull request 正文的任意位置写上 @sourcery-ai summary,即可在你希望的位置随时生成 PR 摘要。你也可以在 pull request 中评论 @sourcery-ai summary 来(重新)生成摘要。
  • 生成审阅者指南: 在 pull request 中评论 @sourcery-ai guide,即可随时(重新)生成审阅者指南。
  • 解决所有 Sourcery 评论: 在 pull request 中评论 @sourcery-ai resolve,即可标记解决所有 Sourcery 评论。如果你已经处理了所有评论且不想再看到它们,这会很有用。
  • 忽略所有 Sourcery 审阅: 在 pull request 中评论 @sourcery-ai dismiss,即可忽略所有现有的 Sourcery 审阅。若你希望从一次全新的审阅开始,这尤其有用——别忘了再评论 @sourcery-ai review 来触发新的审阅!

自定义你的使用体验

访问你的控制面板 以:

  • 启用或禁用审阅功能,例如 Sourcery 自动生成的 pull request 摘要、审阅者指南等。
  • 更改审阅语言。
  • 添加、移除或编辑自定义审阅说明。
  • 调整其他审阅设置。

获得帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Excludes the config/accountsx/ directory from the instance export packaging workflow to avoid bundling plaintext account tokens from the accountsx module.

File-Level Changes

Change Details Files
Adjust instance export behavior so that config/accountsx/ is no longer included in exported/packaged instances.
  • Modify the PageInstance export XAML logic or bound command parameters to skip the config/accountsx/ directory when building the export payload.
  • Ensure that the export UI/behavior still works as before for all other configuration paths while omitting the sensitive accountsx configuration.
Plain Craft Launcher 2/Pages/PageInstance/PageInstanceExport.xaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗨,我已经 review 了你的修改,看起来很棒!


Sourcery 对开源项目是免费的——如果你觉得我们的 review 有帮助,请考虑分享 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈来改进 review。
Original comment in English

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e6f32e49e6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread Plain Craft Launcher 2/Pages/PageInstance/PageInstanceExport.xaml

Copy link
Copy Markdown
Member

你好——我已经审查了你的改动,一切看起来都很棒!


墨渊 对 PCL 社区项目是免费的——如果你觉得我的代码审查有帮助,欢迎分享 ✨
帮我变得更有用吧!请在每条评论上点 👍 或 👎,我会根据你的反馈改进之后的代码审查。
Original comment in English

Hey - I've reviewed your changes and they look great!


MoYuan-CN is free for PCL Community - if you like my reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@pcl-ce-automation pcl-ce-automation Bot added 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 and removed 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 labels Jun 8, 2026
@LuLu-ling LuLu-ling merged commit ac52ce8 into PCL-Community:dev Jun 8, 2026
3 checks passed
@pcl-ce-automation pcl-ce-automation Bot added 👌 完成 相关问题已修复或功能已实现,计划在下次版本更新时正式上线 and removed 🕑 等待合并 已处理完毕,正在等待代码合并入主分支 labels Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XS PR 大小评估:微型 👌 完成 相关问题已修复或功能已实现,计划在下次版本更新时正式上线

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants