Skip to content

Conversation

@seanlynchwv
Copy link
Contributor

@seanlynchwv seanlynchwv commented Sep 8, 2025

Description

It's now possible to set the radius to create rounded corners on rectangle shapes.

        $panel = new AutoShape();
        $panel->setType(AutoShape::TYPE_ROUNDED_RECTANGLE)
            ->setOffsetX($x)
            ->setOffsetY($y)
            ->setWidth($w)
            ->setHeight($h)
            ->setRoundRectCorner(4); // new

Previously the corners were hard coded to a large value making custom designs difficult.

Fixes # (issue)
#854

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@auto-assign auto-assign bot requested a review from Progi1984 September 8, 2025 15:09
@seanlynchwv seanlynchwv changed the title Set Rounded Corners on Rectable Set Rounded Corners on Rectangle Sep 8, 2025
@coveralls
Copy link

coveralls commented Sep 8, 2025

Coverage Status

coverage: 91.69% (+0.05%) from 91.643%
when pulling a48a8a4 on seanlynchwv:feature/set-rounded-rect-corners
into 7018fd8 on PHPOffice:master.

@Progi1984 Progi1984 added this to the 1.3.0 milestone Oct 24, 2025
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedbacks

@seanlynchwv seanlynchwv reopened this Nov 17, 2025
@seanlynchwv
Copy link
Contributor Author

seanlynchwv commented Nov 17, 2025

Hey @Progi1984

CI passes on PHP 7.1 and 7.4+ but fails on 7.2–7.3 because, as far as I can tell, the allowed phpoffice/phpspreadsheet versions (^1.9–^5.0) no longer include any release compatible with PHP 7.2/7.3.

Composer can resolve an old 1.x version on 7.1 and newer versions on 7.4+, but there’s a support gap in between.

This is a dependency/CI matrix mismatch, not an issue introduced by this PR.

For the next major release 1.3.0, could we set php 7.4 as the new minimum? PHP 7.4 reached EOL on November 28, 2022.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants