fix the hamburger menu button #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I should have said: I tried it locally and it fixed the problem. If you open the dev console in your browser, the currently deployed version has a bunch of errors. After my patch they're all gone and no new issues are visible. |
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not great to have to roll back things, but it's the easiest way to fix the problem: the hamburger button is disfunctional (used, e.g., on mobile). @programLyrique do you remember why you updated jQuery to v3 specifically? Was there another problem? If yes, then maybe my patch is bad and someone will need to update Bootstrap to allow jQuery 3+.