You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A+ cohorts previously lived in a separate negative-ID namespace with hand-rolled arithmetic (-timeStep-1, aPlusId+1, etc.), forcing every consumer to branch on task_id < 0 / std::abs(task_id). This PR makes A+ cohorts ordinary one-step cohorts appended right after the last normal ID (firstAPlusId = numAgeGroups + numTimeSteps - 1), exposed via a new getFirstAPlusCohortId() accessor.
SeapodymCohortDependencyAnalyzer.h/.cpp: rewrote the A+ branch of the constructor; updated doc comments/diagram; added getFirstAPlusCohortId().
tests/testTaskStepFarmingCohortAPlus.cxx: replaced sign-based checks with the new ID threshold.
No behavior change: verified the new dependency graph is structurally identical to the old one (isomorphic under the old↔new A+ ID mapping) across several (numAgeGroups, numTimeSteps, ageMature) cases including edge cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.