[W5.7][W17-3] Pakorn Ueareeworakul#3
Open
PakornUe wants to merge 6 commits into
Open
Conversation
Currently, the program does not recognize the word "sort" as a command. As we are going to implement a sort command, this keyword should be recognized and redirected somewhere for testing. So let's add a case to recognize the sort command.
Currently, there is no way to sort the address book. As we are going to implement a sort command, there should be a way to sort the address book by name. So let's add a method to sort the address book.
Currently there is no test available for the sort method in AddressBook. This might prevent us from noticing errors in this method. So let's add a JUnit test.
Currently keying in "sort" is equivalent to keying in "list". This is not the intended behaviour as "sort" is meant to be a command to sort the address book. So let's add and update the JUnit test to make "sort" actually sort the address book.
Currently there are no tests for the sort command. This may cause bugs to pass through. So let's add JUnit and I/O tests for the sort command
Currently there are no documentations for the sort command. This might prevent users from knowing that there is a command that allow them to sort the Address Book. So let's add documentation for the sort command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort command is not present in current version of the software.
Since sorting makes the list easier to read especially when the number people in the address book is high.
So let's add a sort command.