Repository navigation
Cancelled interact event should not send a swing packet. #14375
Description
Observed/Actual behavior
Other players receive an incorrect hand-swing packet
Paper version
26.3-175
Other
I noticed that a check for the result of the interaction event seems to be missing here, which might be helpful for the fix
ServerGamePacketListenerImpl.java line 1222
- } else if (result instanceof InteractionResult.Success success && success.shouldSwing()) {
+ } else if (result instanceof InteractionResult.Success success
+ && success.shouldSwing()
+ && !this.player.gameMode.interactResult) {
this.player.swingAndResetAttackStrength(
hand,
interactAnimation,
success.swingSource() != InteractionResult.SwingSource.PREDICTED
);
}
Activity