Detect rebound middle click clone actions in survival

[TiggerTakkyTTT]

Fixes #11465

[kennytv]

The javadocs of the click type should get a note on what is actually captured, as discussed in the linked issue

[Warriorrrr]

Feels inaccurate to call this "Fix middle click detection in survival", this only makes it so that the case where the client (wrongly?) sends a click packet with the clone action when the MMB is rebound is detected as a MIDDLE click. The client still doesn't send any packets when clicking the MMB with an empty cursor, I don't see how it could be fixed without client side changes.

[TiggerTakkyTTT]

Feels inaccurate to call this "Fix middle click detection in survival", this only makes it so that the case where the client (wrongly?) sends a click packet with the clone action when the MMB is rebound is detected as a MIDDLE click. The client still doesn't send any packets when clicking the MMB with an empty cursor, I don't see how it could be fixed without client side changes.

Yeah, you’re right. This only handles the clone-action packet case when the middle mouse action is rebound, not middle clicks where the client sends no packet. I’ll update the title to make that clearer.