Skip to content

Fix possible CME race conditions for post effects - #14335

Merged
Doc94 merged 2 commits into
PaperMC:mainfrom
GliczDev:fix/post-effects-cme
Oct 4, 2026
Merged

Doc94 merged 2 commits into
PaperMC:mainfrom
GliczDev:fix/post-effects-cme

Conversation

@GliczDev

@GliczDev GliczDev commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

hard to reproduce but did happen to me

@GliczDev
GliczDev requested a review from a team as a code owner October 2, 2026 20:23
@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue Oct 2, 2026
@papermc-projects papermc-projects Bot moved this from Awaiting review to Full approval in Paper PR Queue Oct 2, 2026
@Doc94

Doc94 commented Oct 3, 2026

Copy link
Copy Markdown
Member

Just for know... this can happen in vanilla? or its only related to the introduction of the Effects API?

@GliczDev

GliczDev commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Just for know... this can happen in vanilla? or its only related to the introduction of the Effects API?

Theoretically it could happen in vanilla, but I think it'd be unlikely with /posteffect command. At the same time I wouldn't say it's an issue with post effects API - it's just two threads fighting for the list, which could happen anytime, but really hard to reproduce manually

@Warriorrrr Warriorrrr added the type: bug Something doesn't work as it was intended to. label Oct 4, 2026
@Doc94 Doc94 changed the title Prevent post effects CME race conditions Fix possible CME race conditions for post effects Oct 4, 2026
@Doc94
Doc94 merged commit 6e88e46 into PaperMC:main Oct 4, 2026
4 checks passed
WinPlay02 added a commit to WoMa-Entertainment/Icicle that referenced this pull request Oct 5, 2026
Upstream has released updates that appear to apply and compile correctly

Paper Changes:
PaperMC/Paper@288d43e1 Add getInstrument method to BlockType PaperMC/Paper#14251
PaperMC/Paper@6bc56abc Add `throws CommandSyntaxException` to BasicCommand PaperMC/Paper#14339
PaperMC/Paper@a9d03827 Fix startup crash using autoEnableOnServerStart in plugin-provided datapacks PaperMC/Paper#14238
PaperMC/Paper@ddb45eb4 Fix incorrect container setChanged() called in optimized hopper patch PaperMC/Paper#14269
PaperMC/Paper@60c8e563 Force absolute positions for item frames
PaperMC/Paper@1d254ec4 Fix adding entities with api with already valid passengers PaperMC/Paper#14336
PaperMC/Paper@371c96aa Fix username duplication in chat when defaultRenderer is explicitly set PaperMC/Paper#13868
PaperMC/Paper@6e88e469 Fix possible CME race conditions for post effects PaperMC/Paper#14335
PaperMC/Paper@1a7b6265 Bump JLine to 4.4.6, drop JNI backend as Paper compiles to Java 25 PaperMC/Paper#14323
PaperMC/Paper@1dbde610 Make test block codec conditional
PaperMC/Paper@780818ff  Clear bucket empty event result when fluid placement fails PaperMC/Paper#14345
PaperMC/Paper@2de3a930 Fix silent ignore of Block#getState(boolean) parameter PaperMC/Paper#14341
PaperMC/Paper@65c408ad Don't remove player twice when disconnected during config switch PaperMC/Paper#14346
PaperMC/Paper@4728a906 Fix bundle contents corruption with item obfuscation and shelves PaperMC/Paper#14352
granny added a commit to PurpurMC/Purpur that referenced this pull request Oct 6, 2026
Upstream has released updates that appear to apply and compile correctly

Paper Changes:
PaperMC/Paper@288d43e1 Add getInstrument method to BlockType PaperMC/Paper#14251
PaperMC/Paper@6bc56abc Add `throws CommandSyntaxException` to BasicCommand PaperMC/Paper#14339
PaperMC/Paper@a9d03827 Fix startup crash using autoEnableOnServerStart in plugin-provided datapacks PaperMC/Paper#14238
PaperMC/Paper@ddb45eb4 Fix incorrect container setChanged() called in optimized hopper patch PaperMC/Paper#14269
PaperMC/Paper@60c8e563 Force absolute positions for item frames
PaperMC/Paper@1d254ec4 Fix adding entities with api with already valid passengers PaperMC/Paper#14336
PaperMC/Paper@371c96aa Fix username duplication in chat when defaultRenderer is explicitly set PaperMC/Paper#13868
PaperMC/Paper@6e88e469 Fix possible CME race conditions for post effects PaperMC/Paper#14335
PaperMC/Paper@1a7b6265 Bump JLine to 4.4.6, drop JNI backend as Paper compiles to Java 25 PaperMC/Paper#14323
PaperMC/Paper@1dbde610 Make test block codec conditional
PaperMC/Paper@780818ff  Clear bucket empty event result when fluid placement fails PaperMC/Paper#14345
PaperMC/Paper@2de3a930 Fix silent ignore of Block#getState(boolean) parameter PaperMC/Paper#14341
PaperMC/Paper@65c408ad Don't remove player twice when disconnected during config switch PaperMC/Paper#14346
PaperMC/Paper@4728a906 Fix bundle contents corruption with item obfuscation and shelves PaperMC/Paper#14352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something doesn't work as it was intended to.

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

5 participants