Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14049
Problem
If a wandering trader leaves tracking range while its leashed llama stays visible, the leash can remain attached to the trader's old position when the trader returns.
Solution
When a wandering trader starts being tracked again, resend the leash link for any of its leashed entities that the player is already tracking.
Testing
Built Paper 26.3 from upstream commit
6e88e46with and without this change. In the issue's test world, moved from(8, 50, 53)to(8, 50, -42)and back. The leash remained in the air before the change and reattached to the trader afterward.Before:
After: