Skip to content

Improve build number on releases action - #14354

Closed
kacimiamine wants to merge 1 commit into
PaperMC:mainfrom
kacimiamine:improve-release-action
Closed

kacimiamine wants to merge 1 commit into
PaperMC:mainfrom
kacimiamine:improve-release-action

Conversation

@kacimiamine

Copy link
Copy Markdown
Contributor

Since I saw build 153 released and the next one was 156, I went to fixing the build number logic. What I did is:

  • Read the Minecraft version from gradle.properties.
  • Fetch the latest build of that version using the downloads service.
  • If the version doesn't have build, it will return 0.
  • Increment the build by 1.

I tested it on bash since I can't really test the workflow, but the commands work as intended (tested with 26.3, 26.2 and 26.4 that doesn't exist so I can see it returns 0).

Also moved the step down since it needs checkout first to read the gradle.properties file.

@kacimiamine
kacimiamine requested a review from a team as a code owner October 5, 2026 23:22
@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue Oct 5, 2026
@jpenilla

jpenilla commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Thanks, but we considered this and several other alternatives before settling on the current implementation. This breaks several of the guarantees the current setup provides, especially around build races and retries/reruns. We will look into the skipped build numbers. We do not cancel in-progress overlapping builds, but it seems that multiple builds queued at once only runs the last.

@jpenilla jpenilla closed this Oct 5, 2026
@kacimiamine
kacimiamine deleted the improve-release-action branch October 6, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

2 participants