Remove setRotationKind and getRotationKind from QEC interface
#2250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sengthai
force-pushed
the
rewrite-pqb-interface
branch
from
2b4ab59 to
97d03d8
Compare
sengthai
changed the title
setRotationKind and getRotationKind from QEC interface
sengthai
commented
Dec 1, 2025
rniczh
reviewed
Dec 1, 2025
rniczh
reviewed
Dec 1, 2025
Contributor
There was a problem hiding this comment.
I forgot to post this comment, it should go along with #2250 (review)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2250 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 93 93
Lines 11184 11184
Branches 1065 1065
=======================================
Hits 10911 10911
Misses 208 208
Partials 65 65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Previously,
setRotationKindandgetRotationKindwere implemented for hooks in the QEC interface, but this should not be in theQECOpInterfacebecause that interface also appliesPPMeasurementOp, whereRotationKindis not available.[[sc-104780]]