Add CI to lexicon-python#2
Merged
PhotonicVelocity merged 10 commits intoPhotonicVelocity:mainfrom Apr 13, 2026
Merged
Conversation
PhotonicVelocity
approved these changes
Apr 13, 2026
Owner
PhotonicVelocity
left a comment
There was a problem hiding this comment.
Thanks Mark!
Had to approve you to run workflows and the CI is failing. But I'll merge this and fix it up.
Owner
|
All cleaned up and CI passing — I dropped Python 3.9 support and bumped the minimum to 3.10. 3.9 hit EOL in Oct 2025 and supporting it was requiring a lot of workarounds for type syntax (Union instead of |, etc.). Also added 3.13 and 3.14 to the CI matrix. |
Contributor
Author
|
Thanks @PhotonicVelocity! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviving this PR with a new branch rebased on top of the latest changes on master (effective code changes are the same -- majority of PR is still just formatting and addition of uv.lock)
Hey @PhotonicVelocity thanks for making this library!! It's awesome to have some python tooling for the Lexicon API and the library is well written 🙌 I have some things that I'd love to contribute to the tool if you're open to it :)
Before I start contributing I figure it'd be good to have some CI set up in the repo and include some standard formatting and stuff.
This PR might seem a bit bulky but the vast majority of line changes are actually just formatting and addition of a
uv.lockfile -- these don't change the functionality of the library. The important files to look at are:.github/workflows/ci.yml.github/pull_request_template.mdMakefileREADME.mdFor merging this PR, I would recommend using the
Rebase and mergestrategy in order to keep the repo commit history clean in case more people start to contribute. You can actually even set that as the default/only merge strategy in the repo Settings if you'd like (which I generally recommend for public repos).Summary
uvtest,lint-check,lint-fix,format-check,format-fix, etc.)uv.lockto source control for reproducible installsCode Quality
ruff formatacross the entire codebase for consistent formatting_normalize_id_sequenceintag_categories.pytypes,Iterable,unique_in_order)noqadirectives for intentional wildcard import andE402in testsfieldtofilter_field/edit_fieldintracks_types.pyto avoid shadowing thedataclasses.fieldimportReadOnlyimport intracks_types.pyto fall back totyping_extensionson Python < 3.13Test plan
make testruns formatting, linting, and tests successfully locally