Skip to content

Fix Issue #562 Migrate to maven 4#612

Merged
FDelporte merged 8 commits into
Pi4J:developfrom
osscameroon:562-migrate-to-maven-4
Jul 2, 2026
Merged

Fix Issue #562 Migrate to maven 4#612
FDelporte merged 8 commits into
Pi4J:developfrom
osscameroon:562-migrate-to-maven-4

Conversation

@FanJups

@FanJups FanJups commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix #562

  • Update Maven version from 3.9.4 to 4.0.0-rc-4 and wrapper version 3.3.2 to 3.3.4

    • Upgrade to Maven 4 rc5 (used by pi4j docker image) from rc4

  • Update POMs to use Maven 4.1.0 shcema and namespace

@FanJups FanJups marked this pull request as draft February 17, 2026 19:28
@FDelporte

FDelporte commented Feb 18, 2026

Copy link
Copy Markdown
Member

A draft merge request for the Docker change is ready: Pi4J/pi4j-docker#5
Won't merge until after the V4 release of Pi4J to avoid breaking anything unexpected.

FDelporte
FDelporte reviewed Feb 18, 2026
View reviewed changes
Comment thread libraries/pi4j-library-linuxfs/pom.xml Outdated
Kurocifer added a commit to Kurocifer/pi4j that referenced this pull request Feb 19, 2026
@Kurocifer
build: (issue Pi4J#562, pr Pi4J#612) revert changes on pom files due …
ada3e2b 
…to the formatting performed by mvnup apply command
@Kurocifer Kurocifer mentioned this pull request Feb 19, 2026
Merged
FanJups added a commit to osscameroon/pi4j that referenced this pull request Feb 20, 2026
@FanJups
Merge pull request #4 from Kurocifer/562-migrate-to-maven-4
6a61a7e 
build: (issue Pi4J#562, pr Pi4J#612) revert changes on pom files due to the formatting performed by mvnup apply command
@FanJups FanJups marked this pull request as ready for review February 21, 2026 02:34
@DigitalSmile

DigitalSmile commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

@FDelporte what is blocking this PR to be merged?

@FDelporte

FDelporte commented Jun 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Was waiting for the merge of the plugin removal. Will check current state.

@FanJups can you please update to match the current develop branch en fix merge conflicts? Thanks!

FanJups pushed a commit to osscameroon/pi4j that referenced this pull request Jun 28, 2026
@Kurocifer @FanJups
build: (issue Pi4J#562, pr Pi4J#612) revert changes on pom files due …
bb32bd0 
…to the formatting performed by mvnup apply command
@FanJups FanJups force-pushed the 562-migrate-to-maven-4 branch from a522fef to 715d8b3 Compare June 28, 2026 01:14
@FanJups

FanJups commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

@FDelporte , the rebase is done.

FanJups added a commit to osscameroon/pi4j that referenced this pull request Jun 28, 2026
@FanJups
doc: Issue Pi4J#562 PR Pi4J#612 Add contributors
09b5d2c
@FanJups

FanJups commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

I m trying to figure out what goes wrong 🤔

@FanJups

FanJups commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Maybe , upgrading Maven Compiler Plugin will do the job ?

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12.641 s
[INFO] Finished at: 2026-06-28T12:25:11Z
[INFO] ------------------------------------------------------------------------
Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project pi4j-core: Execution default-compile of goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile failed: Unsupported class file major version 69 -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the '-e' switch
Error: Re-run Maven using the '-X' switch to enable verbose output
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
Error:
Error: After correcting the problems, you can resume the build with the command
Error: mvn [args] -r
Error: Process completed with exit code 1.

@FanJups

FanJups commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

apache/maven-compiler-plugin#961

https://github.com/apache/maven-compiler-plugin/releases/tag/maven-compiler-plugin-3.15.0

I found this, I will give it a try

FanJups added a commit to osscameroon/pi4j that referenced this pull request Jun 29, 2026
@FanJups
build: Issue Pi4J#562 PR Pi4J#612 fix build failure by upgrading mave…
10992de 
…n compiler plugin from 3.13.0 to 3.15.0
@FDelporte

FDelporte commented Jun 29, 2026

Copy link
Copy Markdown
Member

Hi @FanJups, thanks for your ongoing work on this! Build currently fails with this error:

 Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (default-compile) on project pi4j-plugin-ffm: Execution default-compile of goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile failed: Unsupported class file major version 69 -> [Help 1]

Kurocifer and others added 7 commits July 2, 2026 04:58
@Kurocifer @FanJups
build: Pi4J#562 Update POMs to use Maven 4.1.0 shcema and namespace
e239a49 
Update all 15 POMs to Maven 4.1.0 model with new namespace and schema.
Convert <modules> to <subprojects> in parent POMs and add root="true"
attribute to the root POM.

Migration done using mvnup tool with --model and --plugins flags.
Avoided --infer strategy due to incorrect groupId removal from
dependencies.
@FanJups
build: Pi4J#562 Update Maven version from 3.9.4 to 4.0.0-rc-4 and wra…
041c40a 
…pper version 3.3.2 to 3.3.4
@Kurocifer @FanJups
build: (issue Pi4J#562, pr Pi4J#612) revert changes on pom files due …
28b89ad 
…to the formatting performed by mvnup apply command
@Kurocifer @FanJups
build: Pi4J#562 Update POMs to use Maven 4.1.0 shcema and namespace
07e07c5 
- Update all 15 POMs to Maven 4.1.0 model with new namespace and schema.
- Convert <modules> to <subprojects> in parent POMs and add root="true"
attribute to the root POM.
- Avoid unecessary formatting introduced by the mvnup tool

Migration done using mvnup tool with --model and --plugins flags.
Avoided --infer strategy due to incorrect groupId removal from
dependencies.
@FanJups
build: Pi4J#562 Update Maven version from 4.0.0-rc-4 to 4.0.0-rc-5 (p…
815501c 
…i4j docker image maven version)
@FanJups
doc: Issue Pi4J#562 PR Pi4J#612 Add contributors
c5b9748
@FanJups
build: Issue Pi4J#562 PR Pi4J#612 fix build failure by upgrading mave…
d0566b6 
…n compiler plugin from 3.13.0 to 3.15.0
@FanJups FanJups force-pushed the 562-migrate-to-maven-4 branch from 10992de to d0566b6 Compare July 2, 2026 03:59
@FanJups
build: Issue Pi4J#562 PR Pi4J#612 fix build failure by upgrading plug…
a90e994 
…in ffm's maven compiler plugin from 3.14.0 to 3.15.0 & java from 24 to 25
@sonarqubecloud

sonarqubecloud Bot commented Jul 2, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@FanJups

FanJups commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@FDelporte , I got these errors while running locally

[ERROR] Failures:
[ERROR]   BoardCodeReaderTest.testGetBoardCode_FileNotReadable:77 expected: <false> but was: <true>
[ERROR]   CpuInfoReaderTest.testGetCpuRevision_FileNotReadable:67 expected: <false> but was: <true>
[INFO]
[ERROR] Tests run: 69, Failures: 2, Errors: 0, Skipped: 0

Can't wait to see if the build shows the same result here

@FDelporte

FDelporte commented Jul 2, 2026

Copy link
Copy Markdown
Member

Can't wait to see if the build shows the same result here

Builds succeeded! :-)
Thanks, merging now...

@FDelporte FDelporte merged commit e9faaaa into Pi4J:develop Jul 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eitch eitch eitch left review comments
@FDelporte FDelporte FDelporte left review comments
+1 more reviewer
@Kurocifer Kurocifer Kurocifer left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate to Maven 4

5 participants

@FanJups @FDelporte @DigitalSmile @eitch @Kurocifer