Skip to content

Add cgltf#6

Merged
IntegratedQuantum merged 8 commits intoPixelGuys:masterfrom
RanPix:cgltf
Nov 24, 2025
Merged

Add cgltf#6
IntegratedQuantum merged 8 commits intoPixelGuys:masterfrom
RanPix:cgltf

Conversation

@RanPix
Copy link
Copy Markdown
Contributor

@RanPix RanPix commented Nov 6, 2025

needed for future entity model and animation loading

@BoySanic BoySanic moved this to High Priority in PRs to review Nov 14, 2025
Copy link
Copy Markdown
Member

@IntegratedQuantum IntegratedQuantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it through build.zig.zon. The era of pasting C headers into the repo is over.

Also please quickly explain in the PR description what this is needed for.

@IntegratedQuantum IntegratedQuantum moved this from High Priority to In review in PRs to review Nov 14, 2025
@RanPix
Copy link
Copy Markdown
Contributor Author

RanPix commented Nov 15, 2025

i moved it to build.zig.zon, looks correct but i cant build it to see im getting a weird access denied error on vulkan package fetch

@RanPix
Copy link
Copy Markdown
Contributor Author

RanPix commented Nov 15, 2025

added a description

@IntegratedQuantum
Copy link
Copy Markdown
Member

looks correct but i cant build it to see im getting a weird access denied error on vulkan package fetch

Well, that is a problem that we should look into first then.

@RanPix
Copy link
Copy Markdown
Contributor Author

RanPix commented Nov 15, 2025

looks correct but i cant build it to see im getting a weird access denied error on vulkan package fetch

Well, that is a problem that we should look into first then.

.url = "https://github.com/KhronosGroup/MoltenVK/releases/download/v1.4.0/MoltenVK-macos.tar",
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
note: unable to create symlink from 'MoltenVK/dylib' to 'dynamic/dylib': AccessDenied
note: unable to create symlink from 'MoltenVK/dynamic/MoltenVK.xcframework/macos-arm64_x86_64/MoltenVK.framework/Resources' to 'Versions/Current/Resources': AccessDenied
note: unable to create symlink from 'MoltenVK/dynamic/MoltenVK.xcframework/macos-arm64_x86_64/MoltenVK.framework/MoltenVK' to 'Versions/Current/MoltenVK': AccessDenied
note: unable to create symlink from 'MoltenVK/dynamic/MoltenVK.xcframework/macos-arm64_x86_64/MoltenVK.framework/Versions/Current' to 'A': AccessDenied
.url = "https://github.com/harfbuzz/harfbuzz/archive/refs/tags/8.2.2.tar.gz",
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
note: unable to create symlink from 'README' to 'README.md': AccessDenied

thats what im getting, running the command as administrator didnt help

@IntegratedQuantum
Copy link
Copy Markdown
Member

Ah yes, please enable symlinks in the windows developer settings then. (big mistake, using windows to develop stuff)

@RanPix
Copy link
Copy Markdown
Contributor Author

RanPix commented Nov 15, 2025

what version of zig should i use to build this?

@IntegratedQuantum
Copy link
Copy Markdown
Member

0.15.2

@RanPix
Copy link
Copy Markdown
Contributor Author

RanPix commented Nov 15, 2025

now this works

Comment thread lib/cgltf.c Outdated
Comment thread build.zig Outdated
Copy link
Copy Markdown
Member

@IntegratedQuantum IntegratedQuantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to make a release with this right away?

@IntegratedQuantum IntegratedQuantum merged commit eaafd9b into PixelGuys:master Nov 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants